Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1133303007: Oilpan: move NavigationScheduler's redirect actions onto the heap. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: move NavigationScheduler's redirect actions onto the heap. As NavigationScheduler is attached to a LocalFrame, arrange for its ScheduledNavigation actions to be on the Oilpan heap also, so that any of its traceable references are accurately accounted for. R=peria,haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195342

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -24 lines) Patch
M Source/core/loader/NavigationScheduler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/NavigationScheduler.cpp View 1 12 chunks +62 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look. Since LocalFrame is now on the heap (=> the NavigationScheduler part ...
5 years, 7 months ago (2015-05-14 06:57:41 UTC) #2
peria
LGTM This CL is much better than mine, thanks!
5 years, 7 months ago (2015-05-14 07:20:00 UTC) #4
haraken
LGTM
5 years, 7 months ago (2015-05-14 07:52:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133303007/20001
5 years, 7 months ago (2015-05-14 08:08:09 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 08:24:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195342

Powered by Google App Engine
This is Rietveld 408576698