Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 1133263003: Maintain child dependent ComputedStyle flags if propagation stops. (Closed)

Created:
5 years, 7 months ago by rune
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Maintain child dependent ComputedStyle flags if propagation stops. There are two non-inherited flags in ComputedStyle which may be set as a result of calculating the computed style of one of its descendants. Those are the empty state flag, and the explicit inheritance flag. r190990 optimized propagation of inherited properties, but the mentioned flags were not properly set if the propagation stopped at an element which had children that would set these flags. If a child-dependent flag is set in the old style, and there is no need to inherit properties, and no children which needs a style recalc, copy the flags from the old to the new ComputedStyle. If there is no need to inherit properties, but some child needs a style recalc, return Inherit to re-compute the child-dependent flags from its children. R=timloh@chromium.org,esprehn@chromium.org BUG=487216 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
A LayoutTests/fast/css/invalidation/explicit-inheritance-flag.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/explicit-inheritance-flag-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +9 lines, -2 lines 0 comments Download
M Source/core/style/ComputedStyle.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/style/ComputedStyle.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rune
5 years, 7 months ago (2015-05-12 23:55:35 UTC) #1
rune
P1 release-block-stable.
5 years, 7 months ago (2015-05-15 12:42:09 UTC) #3
Timothy Loh
On 2015/05/15 12:42:09, rune wrote: > P1 release-block-stable. lgtm, sorry for the delay
5 years, 7 months ago (2015-05-18 10:05:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133263003/1
5 years, 7 months ago (2015-05-18 10:29:26 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 12:02:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195462

Powered by Google App Engine
This is Rietveld 408576698