Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1133253003: Retreive the BatteryManager as a system service. (Closed)

Created:
5 years, 7 months ago by Yaron
Modified:
5 years, 7 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retreive the BatteryManager as a system service. BatteryManager is offered as a system service and Chrome should not be instantiating it. Updates the code to retrieve the correct instance. Committed: https://crrev.com/9d93b73ca332fd8a6e9babe73415d6e388d1b1b7 Cr-Commit-Position: refs/heads/master@{#329437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yaron
5 years, 7 months ago (2015-05-12 17:14:15 UTC) #2
timvolodine
lgtm thanks!
5 years, 7 months ago (2015-05-12 17:24:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133253003/1
5 years, 7 months ago (2015-05-12 17:26:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 17:55:29 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 17:56:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d93b73ca332fd8a6e9babe73415d6e388d1b1b7
Cr-Commit-Position: refs/heads/master@{#329437}

Powered by Google App Engine
This is Rietveld 408576698