Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1133243009: Remove SK_LEGACY_DRAWPICTURECALLBACK from skia_for_chromium_defines.gypi (Closed)

Created:
5 years, 7 months ago by f(malita)
Modified:
5 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_LEGACY_DRAWPICTURECALLBACK from skia_for_chromium_defines.gypi The flag now lives in Chromium's SkUserConfig.h. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/4e149c09bcf1f02e3f31cd8e7bbe794a00090948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
f(malita)
5 years, 7 months ago (2015-05-18 18:14:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133243009/1
5 years, 7 months ago (2015-05-18 18:14:59 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-18 18:15:00 UTC) #4
reed1
lgtm
5 years, 7 months ago (2015-05-18 18:26:36 UTC) #5
f(malita)
5 years, 7 months ago (2015-05-18 19:14:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4e149c09bcf1f02e3f31cd8e7bbe794a00090948 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698