Refactoring: Remove StyledMarkupAccumulator::shouldAnnotate* methods

Refactoring: Remove StyledMarkupAccumulator::shouldAnnotate* methods

StyledMarkupAccumulator::shouldAnnotate* is used almost only at
StyledMarkupSerializer. This CL replaces these methods calling with
simple equations.

BUG=n/a
TEST=n/a; no behavior change

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195461

[hajimehoshi, 2015-05-18 08:30:37]

hajimehoshi@chromium.org changed reviewers:
+ yosin@chromium.org

[hajimehoshi, 2015-05-18 08:30:37]

PTAL

[yosin_UTC9, 2015-05-18 08:49:35]

lgtm w/ nit

https://codereview.chromium.org/1133243008/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.h (right):

https://codereview.chromium.org/1133243008/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.h:95: bool shouldAnnotate() const {
return m_shouldAnnotate == AnnotateForInterchange || m_shouldAnnotate ==
AnnotateForNavigationTransition; }
Let's implement this function in .cpp file:
http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in...

[hajimehoshi, 2015-05-18 09:46:25]

Thanks!

https://codereview.chromium.org/1133243008/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.h (right):

https://codereview.chromium.org/1133243008/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.h:95: bool shouldAnnotate() const {
return m_shouldAnnotate == AnnotateForInterchange || m_shouldAnnotate ==
AnnotateForNavigationTransition; }
On 2015/05/18 08:49:35, Yosi_UTC9 wrote:
> Let's implement this function in .cpp file:
>
http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in...

Done.

[hajimehoshi, 2015-05-18 09:48:15]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2015-05-18 09:48:15]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1133243008/#ps20001
(title: "yosin's review")

[commit-bot: I haz the power, 2015-05-18 09:48:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133243008/20001

[commit-bot: I haz the power, 2015-05-18 11:11:06]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195461