Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issue 1133243003: Remove Win32k fieldtrial, flag and switches, and make default enabled. (Closed)

Created:
5 years, 7 months ago by Will Harris
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Win32k fieldtrial, flag and switches, and make default enabled. Since the default is now always enabled, remove the test that specifically tests renderers can operate with the switch enabled. BUG=365160 Committed: https://crrev.com/945de9d8719f3a61e5fca9ecaff8e740a4432ae1 Cr-Commit-Position: refs/heads/master@{#329684}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove strings #

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -66 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/content_switches_internal.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Will Harris
PTAL
5 years, 7 months ago (2015-05-13 15:21:52 UTC) #2
nasko
LGTM
5 years, 7 months ago (2015-05-13 17:11:53 UTC) #3
Lei Zhang
lgtm with the string resource removed. https://codereview.chromium.org/1133243003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/1133243003/diff/1/chrome/browser/about_flags.cc#oldcode575 chrome/browser/about_flags.cc:575: IDS_FLAGS_ENABLE_WIN32K_RENDERER_LOCKDOWN_NAME, Remove the ...
5 years, 7 months ago (2015-05-13 17:19:49 UTC) #4
Will Harris
Done. https://codereview.chromium.org/1133243003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/1133243003/diff/1/chrome/browser/about_flags.cc#oldcode575 chrome/browser/about_flags.cc:575: IDS_FLAGS_ENABLE_WIN32K_RENDERER_LOCKDOWN_NAME, On 2015/05/13 17:19:49, Lei Zhang wrote: > ...
5 years, 7 months ago (2015-05-13 17:22:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133243003/20001
5 years, 7 months ago (2015-05-13 17:24:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/52565) win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, ...
5 years, 7 months ago (2015-05-13 17:32:48 UTC) #10
Will Harris
woops typo... ps2 is not the ps you are looking for /handwave.
5 years, 7 months ago (2015-05-13 17:36:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133243003/40001
5 years, 7 months ago (2015-05-13 17:37:01 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 18:47:54 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 18:49:29 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/945de9d8719f3a61e5fca9ecaff8e740a4432ae1
Cr-Commit-Position: refs/heads/master@{#329684}

Powered by Google App Engine
This is Rietveld 408576698