Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1133243002: Revert of Provide accessor for object internal properties that doesn't require debugger to be active (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
kozy, pfeldman, yurys
CC:
v8-dev, Yang, Paweł Hajdan Jr., sergeyv
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Provide accessor for object internal properties that doesn't require debugger to be active (patchset #3 id:40001 of https://codereview.chromium.org/1126103006/) Reason for revert: GC mole issues: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1950/steps/GCMole%20ia32/logs/stdio Original issue's description: > Provide accessor for object internal properties that doesn't require debugger to be active > > Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context. > > Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL. > > BUG=chromium:481845 > LOG=Y > > Committed: https://crrev.com/bdeb0de88c8cf5f2c78f261b45314138f525110d > Cr-Commit-Position: refs/heads/master@{#28362} TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:481845 Committed: https://crrev.com/396236bfa0ba78ad5ca97229e0f6817f573c8202 Cr-Commit-Position: refs/heads/master@{#28365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -201 lines) Patch
M include/v8-debug.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/api.cc View 2 chunks +10 lines, -13 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/mirror-debugger.js View 1 chunk +51 lines, -6 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +0 lines, -150 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Provide accessor for object internal properties that doesn't require debugger to be ...
5 years, 7 months ago (2015-05-12 13:03:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133243002/1
5 years, 7 months ago (2015-05-12 13:03:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 13:04:04 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 13:04:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/396236bfa0ba78ad5ca97229e0f6817f573c8202
Cr-Commit-Position: refs/heads/master@{#28365}

Powered by Google App Engine
This is Rietveld 408576698