Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 1133203003: [iOS] Upstream preference names used by iOS (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream preference names used by iOS BUG=429756 Committed: https://crrev.com/81e3668f66aef998524d914f72ac3bd84ce01fdb Cr-Commit-Position: refs/heads/master@{#330354}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove deprecated prefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
M ios/chrome/browser/pref_names.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
M ios/chrome/browser/pref_names.cc View 1 3 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
Please take a look.
5 years, 7 months ago (2015-05-18 13:14:24 UTC) #2
noyau (Ping after 24h)
lgtm https://codereview.chromium.org/1133203003/diff/1/ios/chrome/browser/pref_names.cc File ios/chrome/browser/pref_names.cc (right): https://codereview.chromium.org/1133203003/diff/1/ios/chrome/browser/pref_names.cc#newcode108 ios/chrome/browser/pref_names.cc:108: extern const char kDoodleQuery[] = "ios.doodle.query"; Remove this ...
5 years, 7 months ago (2015-05-18 13:21:05 UTC) #3
sdefresne
Thank you for the review. https://codereview.chromium.org/1133203003/diff/1/ios/chrome/browser/pref_names.cc File ios/chrome/browser/pref_names.cc (right): https://codereview.chromium.org/1133203003/diff/1/ios/chrome/browser/pref_names.cc#newcode108 ios/chrome/browser/pref_names.cc:108: extern const char kDoodleQuery[] ...
5 years, 7 months ago (2015-05-18 13:22:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133203003/20001
5 years, 7 months ago (2015-05-18 13:22:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-18 13:55:46 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 13:56:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81e3668f66aef998524d914f72ac3bd84ce01fdb
Cr-Commit-Position: refs/heads/master@{#330354}

Powered by Google App Engine
This is Rietveld 408576698