tools/generate_dump.cc - Issue 1133203002: win: Retrieve thread context for x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/generate_dump.cc

Issue 1133203002: win: Retrieve thread context for x64 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: remove temp changes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/generate_dump.cc

diff --git a/tools/generate_dump.cc b/tools/generate_dump.cc

index 818d232dfb5de2ba69ad2cada1dfafa6ea76a7b9..5da9f044196073ef0142c875f0000706fb3c238e 100644

--- a/tools/generate_dump.cc

+++ b/tools/generate_dump.cc

@@ -199,6 +199,7 @@ int GenerateDumpMain(int argc, char* argv[]) {

MinidumpFileWriter minidump;

minidump.InitializeFromSnapshot(&process_snapshot);

if (!minidump.WriteEverything(&file_writer)) {

+ file_writer.Close();

scottmg 2015/05/12 17:48:59 On write failure, the unlink() was failing on Wind

if (unlink(options.dump_path.c_str()) != 0) {

PLOG(ERROR) << "unlink";

}