snapshot/win/process_snapshot_win.cc - Issue 1133203002: win: Retrieve thread context for x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/process_snapshot_win.cc

Issue 1133203002: win: Retrieve thread context for x64 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/win/process_snapshot_win.cc

diff --git a/snapshot/win/process_snapshot_win.cc b/snapshot/win/process_snapshot_win.cc

index b25e8caa1079f2267babe3e53543020338af56e2..33b35e4c4c6737f6e384f5842b34e941f499e90d 100644

--- a/snapshot/win/process_snapshot_win.cc

+++ b/snapshot/win/process_snapshot_win.cc

@@ -149,7 +149,7 @@ std::vector<const ModuleSnapshot*> ProcessSnapshotWin::Modules() const {

}

const ExceptionSnapshot* ProcessSnapshotWin::Exception() const {

- CHECK(false) << "TODO(scottmg): Exception()";

+ //CHECK(false) << "TODO(scottmg): Exception()";

cpu_(ooo_6.6-7.5) 2015/05/12 01:06:50 you meant to delete this line? in chrome we don't

scottmg 2015/05/12 19:37:05 Removed.

return nullptr;

}