Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133173002: Expose TxPower for bluetooth devices during discovery (Closed)

Created:
5 years, 7 months ago by jpawlowski1
Modified:
5 years, 7 months ago
Reviewers:
scheib, armansito
CC:
chromium-reviews, extensions-reviews_chromium.org, hashimoto+watch_chromium.org, scheib+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose TxPower for bluetooth devices during discovery This patch adds wiring to expose TxPower field during device discovery. BUG=407773 R=armansito@chromium.org Committed: https://crrev.com/1b3a81a03eb66b03afbdb4403308d566fb4221c8 Cr-Commit-Position: refs/heads/master@{#329694}

Patch Set 1 #

Total comments: 8

Patch Set 2 : fixes #

Patch Set 3 : added unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -1 line) Patch
M chromeos/dbus/bluetooth_device_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/dbus/bluetooth_device_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_chromeos_unittest.cc View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 1 chunk +6 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_api_utils.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/api/bluetooth.idl View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
jpawlowski1
5 years, 7 months ago (2015-05-11 18:41:55 UTC) #2
armansito
https://codereview.chromium.org/1133173002/diff/1/device/bluetooth/bluetooth_device_mac.mm File device/bluetooth/bluetooth_device_mac.mm (right): https://codereview.chromium.org/1133173002/diff/1/device/bluetooth/bluetooth_device_mac.mm#newcode132 device/bluetooth/bluetooth_device_mac.mm:132: int16 BluetoothDeviceMac::GetInquiryTxPower() const { Add NOTIMPLEMENTED() https://codereview.chromium.org/1133173002/diff/1/device/bluetooth/bluetooth_device_win.cc File device/bluetooth/bluetooth_device_win.cc ...
5 years, 7 months ago (2015-05-12 01:09:14 UTC) #3
jpawlowski1
https://codereview.chromium.org/1133173002/diff/1/device/bluetooth/bluetooth_device_mac.mm File device/bluetooth/bluetooth_device_mac.mm (right): https://codereview.chromium.org/1133173002/diff/1/device/bluetooth/bluetooth_device_mac.mm#newcode132 device/bluetooth/bluetooth_device_mac.mm:132: int16 BluetoothDeviceMac::GetInquiryTxPower() const { On 2015/05/12 01:09:13, armansito wrote: ...
5 years, 7 months ago (2015-05-12 08:11:01 UTC) #5
armansito
Can you add a unit test that verifies that you return kUnknownPower if the property ...
5 years, 7 months ago (2015-05-13 00:55:01 UTC) #6
scheib
extensions/common/api/bluetooth.idl LGTM
5 years, 7 months ago (2015-05-13 16:52:29 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133173002/40001
5 years, 7 months ago (2015-05-13 17:05:12 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 18:57:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133173002/40001
5 years, 7 months ago (2015-05-13 19:07:51 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 19:13:45 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:14:32 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1b3a81a03eb66b03afbdb4403308d566fb4221c8
Cr-Commit-Position: refs/heads/master@{#329694}

Powered by Google App Engine
This is Rietveld 408576698