Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issue 1133163003: mac: Fix an error in a unit_test from linking against the 10.10 SDK. (Closed)

Created:
5 years, 7 months ago by erikchen
Modified:
5 years, 7 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Fix an error in a unit_test from linking against the 10.10 SDK. When an application is linked against an OSX 10.9+ SDK, a blit will fail if the source and destination color formats do not match. BUG=484203 Committed: https://crrev.com/e5cc32ead01f46e914d0f8b090032fc28de75438 Cr-Commit-Position: refs/heads/master@{#329242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
erikchen
zmo: Please review.
5 years, 7 months ago (2015-05-11 18:12:15 UTC) #2
Zhenyao Mo
LGTM Thanks for your persistence on getting to the bottom of this bug.
5 years, 7 months ago (2015-05-11 19:37:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133163003/1
5 years, 7 months ago (2015-05-11 19:40:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/70654) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-11 19:49:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133163003/1
5 years, 7 months ago (2015-05-11 21:23:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 21:51:19 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 21:52:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5cc32ead01f46e914d0f8b090032fc28de75438
Cr-Commit-Position: refs/heads/master@{#329242}

Powered by Google App Engine
This is Rietveld 408576698