Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1133153002: Move Indexed DB Blink API headers to public/platform/modules/indexeddb (2/3) (Closed)

Created:
5 years, 7 months ago by jsbell
Modified:
5 years, 7 months ago
CC:
cmumford, chromium-reviews, darin-cc_chromium.org, dgrogan, jam, jsbell+idb_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Indexed DB Blink API headers to public/platform/modules/indexeddb (2/3) This allows the WebIDB* APIs to be covered by Indexed DB OWNERS Three sided patch: [1] http://crrev.com/1140573002 Blink - move headers, add temp redirects [2] This patch - update include paths in chromium [3] http://crrev.com/1124333009 Blink - remove temp redirects BUG=453032 Committed: https://crrev.com/7f68211125110435de0ad761976bb8b9d03d83ea Cr-Commit-Position: refs/heads/master@{#329432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -46 lines) Patch
M content/browser/DEPS View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_cursor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_transaction_coordinator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_key_builders.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/indexed_db/webidbcursor_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/indexed_db/webidbcursor_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/indexed_db/webidbfactory_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/DEPS View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/indexed_db/indexed_db_key.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/indexed_db/indexed_db_key_path.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/indexed_db/indexed_db_key_range.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
jsbell
cmumford@, jochen@ - please take a look?
5 years, 7 months ago (2015-05-11 17:36:13 UTC) #1
jsbell
(actually adding reviewers...) cmumford@, jochen@ - please take a look?
5 years, 7 months ago (2015-05-11 17:37:11 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-11 23:35:07 UTC) #4
cmumford
lgtm
5 years, 7 months ago (2015-05-12 16:04:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133153002/1
5 years, 7 months ago (2015-05-12 16:27:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63012)
5 years, 7 months ago (2015-05-12 16:34:21 UTC) #9
jsbell
tsepez@ - can I get a rubber stamp for the messages.h change?
5 years, 7 months ago (2015-05-12 16:35:19 UTC) #11
Tom Sepez
RS LGTM for changing include paths.
5 years, 7 months ago (2015-05-12 16:49:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133153002/1
5 years, 7 months ago (2015-05-12 16:49:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 17:28:35 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 17:29:24 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f68211125110435de0ad761976bb8b9d03d83ea
Cr-Commit-Position: refs/heads/master@{#329432}

Powered by Google App Engine
This is Rietveld 408576698