Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: ash/metrics/task_switch_metrics_recorder.cc

Issue 1133123003: Added metrics to track the time between task switches done via the shelf. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed oshima@'s nit from patch set 3. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "ash/metrics/task_switch_metrics_recorder.h"
6
7 #include "ash/metrics/task_switch_time_tracker.h"
8
9 namespace ash {
10
11 namespace {
12
13 const char kShelf_histogram[] = "Ash.Shelf.TimeBetweenNavigateToTaskSwitches";
Alexei Svitkine (slow) 2015/05/14 14:51:54 Nit: kShelfHistogram
bruthig 2015/05/14 15:35:20 Done.
14
15 // Returns the histogram name for the given |task_switch_source|.
16 const char* GetHistogramName(
17 TaskSwitchMetricsRecorder::TaskSwitchSource task_switch_source) {
18 switch (task_switch_source) {
19 case TaskSwitchMetricsRecorder::kShelf:
20 return kShelf_histogram;
21 }
22 NOTREACHED();
23 return nullptr;
24 }
25
26 } // namespace
27
28 TaskSwitchMetricsRecorder::TaskSwitchMetricsRecorder() {
29 }
30
31 TaskSwitchMetricsRecorder::~TaskSwitchMetricsRecorder() {
32 }
33
34 void TaskSwitchMetricsRecorder::OnTaskSwitch(
35 TaskSwitchSource task_switch_source) {
36 TaskSwitchTimeTracker* task_switch_time_tracker =
37 FindTaskSwitchTimeTracker(task_switch_source);
38 if (!task_switch_time_tracker)
39 AddTaskSwitchTimeTracker(task_switch_source);
40
41 task_switch_time_tracker = FindTaskSwitchTimeTracker(task_switch_source);
42 CHECK(task_switch_time_tracker);
43
44 task_switch_time_tracker->OnTaskSwitch();
45 }
46
47 TaskSwitchTimeTracker* TaskSwitchMetricsRecorder::FindTaskSwitchTimeTracker(
48 TaskSwitchSource task_switch_source) {
49 return histogram_map_.get(task_switch_source);
50 }
51
52 void TaskSwitchMetricsRecorder::AddTaskSwitchTimeTracker(
53 TaskSwitchSource task_switch_source) {
54 CHECK(histogram_map_.find(task_switch_source) == histogram_map_.end());
55
56 const char* histogram_name = GetHistogramName(task_switch_source);
57 DCHECK(histogram_name);
58
59 histogram_map_.add(task_switch_source,
60 scoped_ptr<TaskSwitchTimeTracker>(
Alexei Svitkine (slow) 2015/05/14 14:51:54 make_scoped_ptr?
bruthig 2015/05/14 15:35:20 Done.
61 new TaskSwitchTimeTracker(histogram_name)));
62 }
63
64 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698