Issue 113310: Split the RUNTIME_FUNCTION_LIST_ALWAYS macro into two as this macro is very l...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113310: Split the RUNTIME_FUNCTION_LIST_ALWAYS macro into two as this macro is very l... (Closed)

Created:
11 years, 7 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
Mike Belshe, iposva

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Split the RUNTIME_FUNCTION_LIST_ALWAYS macro into two as this macro is very large for Visual Studio's intellisense operation thus causing it to crash. Fixes bug http://code.google.com/p/chromium/issues/detail?id=11837 Bug=11837

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	src/runtime.h	View	1 2	3 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

iposva

Small comment, otherwise LGTM. -Ivan http://codereview.chromium.org/113310/diff/4/5 File src/runtime.h (right): http://codereview.chromium.org/113310/diff/4/5#newcode40 Line 40: #define RUNTIME_FUNCTION_LIST_ALWAYS_1(F) \ ...

11 years, 7 months ago (2009-05-12 23:33:22 UTC) #2

ananta

11 years, 7 months ago (2009-05-13 01:52:24 UTC) #3

On 2009/05/12 23:33:22, iposva wrote:
> Small comment, otherwise LGTM.
> 
> -Ivan
> 
> http://codereview.chromium.org/113310/diff/4/5
> File src/runtime.h (right):
> 
> http://codereview.chromium.org/113310/diff/4/5#newcode40
> Line 40: #define RUNTIME_FUNCTION_LIST_ALWAYS_1(F) \
> Please explain in a comment why this list is split in multiple pieces here.
See
> v8-counters.h STATS_COUNTER_LIST for an example.
Done.

Expand Messages | Collapse Messages