[iOS] Reduce UpdateDelay

[iOS] Reduce UpdateDelay

On iOS, having the max at 60 results in the topsites database being
not updated often enough since the app isn't usually running for long
stretches of time. Reduce the value to 5 minutes instead and fix unit
tests.

BUG=485070
Committed: https://crrev.com/9d4007a7670c72982a1c3bf6f549f76df325f57b
Cr-Commit-Position: refs/heads/master@{#329424}

[sdefresne, 2015-05-11 14:08:20]

sdefresne@chromium.org changed reviewers:
+ sky@chromium.org

[sdefresne, 2015-05-11 14:08:21]

Please take a look.

[sky, 2015-05-11 15:10:00]

https://codereview.chromium.org/1133093002/diff/1/components/history/core/bro...
File components/history/core/browser/top_sites_impl.cc (right):

https://codereview.chromium.org/1133093002/diff/1/components/history/core/bro...
components/history/core/browser/top_sites_impl.cc:81: // On mobile, having the
max at 60 results in the topsites database being
Your comment says mobile, you're ifdef says ios. Should the ifdef be for android
too?

[sdefresne, 2015-05-11 15:49:21]

https://codereview.chromium.org/1133093002/diff/1/components/history/core/bro...
File components/history/core/browser/top_sites_impl.cc (right):

https://codereview.chromium.org/1133093002/diff/1/components/history/core/bro...
components/history/core/browser/top_sites_impl.cc:81: // On mobile, having the
max at 60 results in the topsites database being
On 2015/05/11 15:10:00, sky wrote:
> Your comment says mobile, you're ifdef says ios. Should the ifdef be for
android
> too?

I don't know. Do you know who I can ask?

[sky, 2015-05-11 16:19:01]

Not sure. Maybe Grace? While chrome isn't the active app for long stretches of
time on android I suspect it isn't killed unless there is memory pressure. We
may have histograms that track uptime, but I'm not positive there. Sorry for the
lack of help.

[sdefresne, 2015-05-11 16:53:20]

sdefresne@chromium.org changed reviewers:
+ klobag@chromium.org

[sdefresne, 2015-05-11 16:53:20]

klobag: do you think we want this code on Android? On iOS the app is usually
quickly killed after being backgrounded. If this is also the case on Android
then we may want it, otherwise I'll keep it as iOS only (and update the
comment).

[sdefresne, 2015-05-12 16:41:17]

I've updated the comment to state that the fix is iOS specific (as the app is
killed quickly when in background). Can you take another look?

[sky, 2015-05-12 16:47:43]

LGTM

[sdefresne, 2015-05-12 16:48:46]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-05-12 16:48:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133093002/20001

[commit-bot: I haz the power, 2015-05-12 16:58:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-12 16:59:34]

Patchset 2 (id:??) landed as
https://crrev.com/9d4007a7670c72982a1c3bf6f549f76df325f57b
Cr-Commit-Position: refs/heads/master@{#329424}

[pink (ping after 24hrs), 2015-05-12 17:00:44]

Did you talk to Clank and ask why they don't want this patch?

On Tue, May 12, 2015 at 12:59 PM, <commit-bot@chromium.org> wrote:

> Patchset 2 (id:??) landed as
> https://crrev.com/9d4007a7670c72982a1c3bf6f549f76df325f57b
> Cr-Commit-Position: refs/heads/master@{#329424}
>
> https://codereview.chromium.org/1133093002/
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.