content/common/push_messaging_messages.h - Issue 1133083002: Reject the permissionState promise with NotSupported Exception (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/push_messaging_messages.h

Issue 1133083002: Reject the permissionState promise with NotSupported Exception (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/push_messaging/push_provider.cc ('K') | « content/child/push_messaging/push_provider.cc ('k') | content/public/browser/push_messaging_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/push_messaging_messages.h

diff --git a/content/common/push_messaging_messages.h b/content/common/push_messaging_messages.h

index 73c11fe08b5fa5ec8c1c66925eb206a2c8ea3664..dcf48b1b0d36590abf79f2e82e50529b2ab09f3c 100644

--- a/content/common/push_messaging_messages.h

+++ b/content/common/push_messaging_messages.h

@@ -71,8 +71,9 @@ IPC_MESSAGE_CONTROL2(PushMessagingMsg_GetPermissionStatusSuccess,

int32_t /* request_id */,

blink::WebPushPermissionStatus /* status */)

-IPC_MESSAGE_CONTROL1(PushMessagingMsg_GetPermissionStatusError,

- int32_t /* request_id */)

+IPC_MESSAGE_CONTROL2(PushMessagingMsg_GetPermissionStatusError,

+ int32_t /* request_id */,

+ blink::WebPushError::ErrorType /* error_type */)

// Messages sent from the child process to the browser.