Reject the permissionState promise with NotSupported Exception (2/3)

content/child/push_messaging/push_provider.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/push_messaging/push_provider.h"
 
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/stl_util.h"
 #include "base/threading/thread_local.h"
@@ skipping 261 matching lines @@
   blink::WebPushPermissionStatusCallbacks* callbacks =
       permission_status_callbacks_.Lookup(request_id);
   if (!callbacks)
     return;
 
   callbacks->onSuccess(&status);
 
   permission_status_callbacks_.Remove(request_id);
 }
 
-void PushProvider::OnGetPermissionStatusError(int request_id) {
+void PushProvider::OnGetPermissionStatusError(
+    int request_id,
+    blink::WebPushError::ErrorType error) {
   blink::WebPushPermissionStatusCallbacks* callbacks =
       permission_status_callbacks_.Lookup(request_id);
   if (!callbacks)
     return;
 
-  callbacks->onError();
+  std::string error_message;
+  if (error == blink::WebPushError::ErrorTypeNotSupported) {
+    error_message =
+        "push subscriptions that don't enable userVisibleOnly are not "
+        "supported.";

[Peter Beverloo, 2015/05/11 12:56:07]

Capitalization - it's a sentence.

[Miguel Garcia, 2015/05/11 13:50:38]

Done.

+  } else {
+    error_message = "";

[Peter Beverloo, 2015/05/11 12:56:07]

No need to set it to an empty string - the constructor already implies this.

[Miguel Garcia, 2015/05/11 13:50:38]

Done.

+  }
+
+  scoped_ptr<blink::WebPushError> web_error(new blink::WebPushError(
+      error, blink::WebString::fromUTF8(error_message)));
+
+  callbacks->onError(web_error.release());
 
   permission_status_callbacks_.Remove(request_id);
 }
 
 }  // namespace content