Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1133063002: Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf (Closed)

Created:
5 years, 7 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 7 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf TBR=tommi BUG=486654 Committed: https://crrev.com/fc57f2cec564c344e3e17023b41c008f574b65a7 Cr-Commit-Position: refs/heads/master@{#329147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/media/webrtc_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
henrika (OOO until Aug 14)
Patrik, as discussed off-line. Please review.
5 years, 7 months ago (2015-05-11 08:32:12 UTC) #2
phoglund_chromium
lgtm
5 years, 7 months ago (2015-05-11 09:09:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133063002/1
5 years, 7 months ago (2015-05-11 09:10:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62560)
5 years, 7 months ago (2015-05-11 09:21:37 UTC) #7
henrika (OOO until Aug 14)
This CL will not be landed since the v8 roll has now been reverted; hence ...
5 years, 7 months ago (2015-05-11 12:18:53 UTC) #8
henrika (OOO until Aug 14)
See https://codereview.chromium.org/1124333006/ for details.
5 years, 7 months ago (2015-05-11 12:19:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133063002/1
5 years, 7 months ago (2015-05-11 13:53:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 13:56:34 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fc57f2cec564c344e3e17023b41c008f574b65a7 Cr-Commit-Position: refs/heads/master@{#329147}
5 years, 7 months ago (2015-05-11 13:57:30 UTC) #13
phoglund_chromium
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1141533002/ by phoglund@chromium.org. ...
5 years, 7 months ago (2015-05-12 08:41:36 UTC) #14
henrika (OOO until Aug 14)
5 years, 7 months ago (2015-05-12 08:47:44 UTC) #15
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698