Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1133053004: sql: Remove basictypes.h includes. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sql: Remove basictypes.h includes. * Use the standard integer types from stdint.h instead. * Use macros.h for the DISALLOW_COPY_AND_ASSIGN macro. BUG=138542 TEST=sql_unittests R=shess@chromium.org Committed: https://crrev.com/720d4f346cee3fa9ea9c58b845550e7066a80ec2 Cr-Commit-Position: refs/heads/master@{#329256}

Patch Set 1 #

Total comments: 2

Patch Set 2 : shess review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M sql/connection.h View 2 chunks +3 lines, -2 lines 0 comments Download
M sql/connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sql/connection_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sql/meta_table.h View 2 chunks +4 lines, -3 lines 0 comments Download
M sql/meta_table.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sql/meta_table_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M sql/recovery.h View 1 chunk +1 line, -2 lines 0 comments Download
M sql/statement.h View 3 chunks +4 lines, -3 lines 0 comments Download
M sql/statement.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sql/test/scoped_error_ignorer.h View 1 chunk +1 line, -1 line 0 comments Download
M sql/test/test_helpers.h View 1 chunk +0 lines, -1 line 0 comments Download
M sql/test/test_helpers.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sql/transaction.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
tfarina
5 years, 7 months ago (2015-05-11 20:18:18 UTC) #1
Scott Hess - ex-Googler
Please s/int64/int64_t/ in the unit tests and test/test_helpers.cc in this CL. https://codereview.chromium.org/1133053004/diff/1/sql/statement.cc File sql/statement.cc (right): ...
5 years, 7 months ago (2015-05-11 20:34:23 UTC) #2
tfarina
Done. PTAL https://codereview.chromium.org/1133053004/diff/1/sql/statement.cc File sql/statement.cc (right): https://codereview.chromium.org/1133053004/diff/1/sql/statement.cc#newcode303 sql/statement.cc:303: std::vector<unsigned char>* val) const { On 2015/05/11 ...
5 years, 7 months ago (2015-05-11 20:39:07 UTC) #3
Scott Hess - ex-Googler
thanks, lgtm.
5 years, 7 months ago (2015-05-11 20:49:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133053004/20001
5 years, 7 months ago (2015-05-11 22:23:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 22:31:34 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 22:32:28 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/720d4f346cee3fa9ea9c58b845550e7066a80ec2
Cr-Commit-Position: refs/heads/master@{#329256}

Powered by Google App Engine
This is Rietveld 408576698