Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1133033003: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed compile error in webmediaplayer_impl Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 201aeddc87164fa8660476af330d25bde350a633..9aa87a397b684a3e486612525992b3d0e2423870 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -191,6 +191,7 @@
#include "content/renderer/vr/vr_dispatcher.h"
#endif
+using blink::WebContentDecryptionModule;
using blink::WebContextMenuData;
using blink::WebData;
using blink::WebDataSource;
@@ -206,6 +207,7 @@ using blink::WebHTTPBody;
using blink::WebLocalFrame;
using blink::WebMediaPlayer;
using blink::WebMediaPlayerClient;
+using blink::WebMediaPlayerEncryptedMediaClient;
using blink::WebNavigationPolicy;
using blink::WebNavigationType;
using blink::WebNode;
@@ -1942,11 +1944,12 @@ blink::WebPlugin* RenderFrameImpl::createPlugin(
#endif // defined(ENABLE_PLUGINS)
}
-blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
+WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
blink::WebLocalFrame* frame,
const blink::WebURL& url,
- blink::WebMediaPlayerClient* client,
- blink::WebContentDecryptionModule* initial_cdm) {
+ WebMediaPlayerClient* client,
+ WebMediaPlayerEncryptedMediaClient* encrypted_client,
+ WebContentDecryptionModule* initial_cdm) {
#if defined(VIDEO_HOLE)
if (!contains_media_player_) {
render_view_->RegisterVideoHoleFrame(this);
@@ -1960,7 +1963,8 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
return CreateWebMediaPlayerForMediaStream(client);
#if defined(OS_ANDROID)
- return CreateAndroidWebMediaPlayer(client, GetMediaPermission(), initial_cdm);
+ return CreateAndroidWebMediaPlayer(client, encrypted_client,
+ GetMediaPermission(), initial_cdm);
#else
scoped_refptr<media::MediaLog> media_log(new RenderMediaLog());
@@ -1991,8 +1995,8 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
#endif // defined(ENABLE_MEDIA_MOJO_RENDERER)
return new media::WebMediaPlayerImpl(
- frame, client, weak_factory_.GetWeakPtr(), media_renderer_factory.Pass(),
- GetCdmFactory(), params);
+ frame, client, encrypted_client, weak_factory_.GetWeakPtr(),
+ media_renderer_factory.Pass(), GetCdmFactory(), params);
#endif // defined(OS_ANDROID)
}
@@ -3749,18 +3753,18 @@ blink::WebVRClient* RenderFrameImpl::webVRClient() {
}
#endif
-void RenderFrameImpl::DidPlay(blink::WebMediaPlayer* player) {
+void RenderFrameImpl::DidPlay(WebMediaPlayer* player) {
Send(new FrameHostMsg_MediaPlayingNotification(
routing_id_, reinterpret_cast<int64>(player), player->hasVideo(),
player->hasAudio(), player->isRemote()));
}
-void RenderFrameImpl::DidPause(blink::WebMediaPlayer* player) {
+void RenderFrameImpl::DidPause(WebMediaPlayer* player) {
Send(new FrameHostMsg_MediaPausedNotification(
routing_id_, reinterpret_cast<int64>(player)));
}
-void RenderFrameImpl::PlayerGone(blink::WebMediaPlayer* player) {
+void RenderFrameImpl::PlayerGone(WebMediaPlayer* player) {
DidPause(player);
}
@@ -4877,9 +4881,9 @@ NavigationState* RenderFrameImpl::CreateNavigationStateFromPending() {
WebMediaPlayer* RenderFrameImpl::CreateAndroidWebMediaPlayer(
WebMediaPlayerClient* client,
+ WebMediaPlayerEncryptedMediaClient* encrypted_client,
media::MediaPermission* media_permission,
- blink::WebContentDecryptionModule* initial_cdm) {
-
+ WebContentDecryptionModule* initial_cdm) {
scoped_refptr<StreamTextureFactory> stream_texture_factory;
if (SynchronousCompositorFactory* factory =
SynchronousCompositorFactory::GetInstance()) {
@@ -4907,8 +4911,9 @@ WebMediaPlayer* RenderFrameImpl::CreateAndroidWebMediaPlayer(
}
return new WebMediaPlayerAndroid(
- frame_, client, weak_factory_.GetWeakPtr(), GetMediaPlayerManager(),
- GetCdmFactory(), media_permission, initial_cdm, stream_texture_factory,
+ frame_, client, encrypted_client, weak_factory_.GetWeakPtr(),
+ GetMediaPlayerManager(), GetCdmFactory(), media_permission, initial_cdm,
+ stream_texture_factory,
RenderThreadImpl::current()->GetMediaThreadTaskRunner(),
new RenderMediaLog());
}

Powered by Google App Engine
This is Rietveld 408576698