Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: content/renderer/media/android/webmediaplayer_android.cc

Issue 1133033003: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed compile error in webmediaplayer_impl Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/webmediaplayer_android.cc
diff --git a/content/renderer/media/android/webmediaplayer_android.cc b/content/renderer/media/android/webmediaplayer_android.cc
index 15494816716e23c230c96d9aef71cb4399e45bfc..ecbe475600af6e41e18bde15633e9b1bb2bf4771 100644
--- a/content/renderer/media/android/webmediaplayer_android.cc
+++ b/content/renderer/media/android/webmediaplayer_android.cc
@@ -148,6 +148,7 @@ namespace content {
WebMediaPlayerAndroid::WebMediaPlayerAndroid(
blink::WebFrame* frame,
blink::WebMediaPlayerClient* client,
+ blink::WebMediaPlayerEncryptedMediaClient* encrypted_client,
base::WeakPtr<media::WebMediaPlayerDelegate> delegate,
RendererMediaPlayerManager* player_manager,
media::CdmFactory* cdm_factory,
@@ -159,6 +160,7 @@ WebMediaPlayerAndroid::WebMediaPlayerAndroid(
: RenderFrameObserver(RenderFrame::FromWebFrame(frame)),
frame_(frame),
client_(client),
+ encrypted_client_(encrypted_client),
delegate_(delegate),
buffered_(static_cast<size_t>(1)),
media_task_runner_(task_runner),
@@ -816,7 +818,7 @@ void WebMediaPlayerAndroid::OnBufferingUpdate(int percentage) {
void WebMediaPlayerAndroid::OnSeekRequest(const base::TimeDelta& time_to_seek) {
DCHECK(main_thread_checker_.CalledOnValidThread());
- client_->requestSeek(time_to_seek.InSecondsF());
+ client_->mediaPlayerRequestSeek(time_to_seek.InSecondsF());
}
void WebMediaPlayerAndroid::OnSeekComplete(
@@ -1690,7 +1692,7 @@ void WebMediaPlayerAndroid::ContentDecryptionModuleAttached(
void WebMediaPlayerAndroid::OnKeyAdded(const std::string& session_id) {
EmeUMAHistogramCounts(current_key_system_, "KeyAdded", 1);
- client_->keyAdded(
+ encrypted_client_->keyAdded(
WebString::fromUTF8(media::GetPrefixedKeySystemName(current_key_system_)),
WebString::fromUTF8(session_id));
}
@@ -1709,7 +1711,7 @@ void WebMediaPlayerAndroid::OnKeyError(const std::string& session_id,
short_system_code = static_cast<unsigned short>(system_code);
}
- client_->keyError(
+ encrypted_client_->keyError(
WebString::fromUTF8(media::GetPrefixedKeySystemName(current_key_system_)),
WebString::fromUTF8(session_id),
static_cast<blink::WebMediaPlayerClient::MediaKeyErrorCode>(error_code),
@@ -1721,12 +1723,10 @@ void WebMediaPlayerAndroid::OnKeyMessage(const std::string& session_id,
const GURL& destination_url) {
DCHECK(destination_url.is_empty() || destination_url.is_valid());
- client_->keyMessage(
+ encrypted_client_->keyMessage(
WebString::fromUTF8(media::GetPrefixedKeySystemName(current_key_system_)),
- WebString::fromUTF8(session_id),
- message.empty() ? NULL : &message[0],
- message.size(),
- destination_url);
+ WebString::fromUTF8(session_id), message.empty() ? NULL : &message[0],
+ message.size(), destination_url);
}
void WebMediaPlayerAndroid::OnMediaSourceOpened(
@@ -1754,17 +1754,17 @@ void WebMediaPlayerAndroid::OnEncryptedMediaInitData(
if (init_data_type_ == media::EmeInitDataType::UNKNOWN)
init_data_type_ = init_data_type;
- client_->encrypted(ConvertToWebInitDataType(init_data_type),
- vector_as_array(&init_data), init_data.size());
+ encrypted_client_->encrypted(ConvertToWebInitDataType(init_data_type),
+ vector_as_array(&init_data), init_data.size());
}
void WebMediaPlayerAndroid::OnWaitingForDecryptionKey() {
- client_->didBlockPlaybackWaitingForKey();
+ encrypted_client_->didBlockPlaybackWaitingForKey();
// TODO(jrummell): didResumePlaybackBlockedForKey() should only be called
// when a key has been successfully added (e.g. OnSessionKeysChange() with
// |has_additional_usable_key| = true). http://crbug.com/461903
- client_->didResumePlaybackBlockedForKey();
+ encrypted_client_->didResumePlaybackBlockedForKey();
}
void WebMediaPlayerAndroid::OnCdmContextReady(media::CdmContext* cdm_context) {

Powered by Google App Engine
This is Rietveld 408576698