Eliminate MediaPlayer & MediaPlayerClient abstractions

components/html_viewer/frame.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_HTML_VIEWER_FRAME_H_
 #define COMPONENTS_HTML_VIEWER_FRAME_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 115 matching lines @@
   void OnViewInputEvent(mojo::View* view, const mojo::EventPtr& event) override;
   void OnViewFocusChanged(mojo::View* gained_focus,
                           mojo::View* lost_focus) override;
 
   // WebViewClient methods:
   virtual void initializeLayerTreeView() override;
   virtual blink::WebLayerTreeView* layerTreeView() override;
   virtual blink::WebStorageNamespace* createSessionStorageNamespace();
 
   // WebFrameClient methods:
   virtual blink::WebMediaPlayer* createMediaPlayer(

[Srirama, 2015/07/10 15:29:30]

I have checked the code and couldn't find the use for this method. So i haven't
added the 2nd method here. Correct me if i am wrong.

[ddorwin, 2015/07/10 17:56:56]

I'm not sure what you mean. This is the WebFrameClient for the Mojo HTML Viewer
app. Blink would call this for media in HTML Viewer.
As-is, I think this would break media in the viewer.

[Srirama, 2015/07/10 18:36:02]

I mean, when i changed this function prototype to include new parameter, i
didn't get any build error, i am verifying the components changes with "ninja -C
out/Debug mandoline:all". So i thought it is not invoked anywhere.

[ddorwin, 2015/07/10 18:47:43]

That will only catch compile failures. Since WebFrameClient.h has default
implementations for all functions, the compile will succeed. I expect any
media-using test would fail, though.

[Srirama, 2015/07/11 08:44:10]

Done.

       blink::WebLocalFrame* frame,
       const blink::WebURL& url,
       blink::WebMediaPlayerClient* client,
+      blink::WebMediaPlayerEncryptedMediaClient* encrypted_client,
       blink::WebContentDecryptionModule* initial_cdm);
   virtual blink::WebFrame* createChildFrame(
       blink::WebLocalFrame* parent,
       blink::WebTreeScopeType scope,
       const blink::WebString& frame_ame,
       blink::WebSandboxFlags sandbox_flags);
   virtual void frameDetached(blink::WebFrame* frame,
                              blink::WebFrameClient::DetachType type);
   virtual blink::WebCookieJar* cookieJar(blink::WebLocalFrame* frame);
   virtual blink::WebNavigationPolicy decidePolicyForNavigation(
@@ skipping 37 matching lines @@
   blink::WebTreeScopeType scope_;
 
   base::WeakPtrFactory<Frame> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Frame);
 };
 
 }  // namespace html_viewer
 
 #endif  // COMPONENTS_HTML_VIEWER_FRAME_H_