Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: gpu/blink/webgraphicscontext3d_impl.cc

Issue 1133033002: Update GetTexParameter* and TexParameter* for ES3 in GPU command buffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/blink/webgraphicscontext3d_impl.cc
diff --git a/gpu/blink/webgraphicscontext3d_impl.cc b/gpu/blink/webgraphicscontext3d_impl.cc
index d35bb9debb37e6157cb6de2be7d2fc3b02e7ffb7..66be8254e07bf1bfc6f0ed55dbffaae45eba3eb2 100644
--- a/gpu/blink/webgraphicscontext3d_impl.cc
+++ b/gpu/blink/webgraphicscontext3d_impl.cc
@@ -639,17 +639,8 @@ DELEGATE_TO_GL_9(texImage2D, TexImage2D,
DELEGATE_TO_GL_3(texParameterf, TexParameterf,
WGC3Denum, WGC3Denum, WGC3Dfloat);
-static const unsigned int kTextureWrapR = 0x8072;
-
void WebGraphicsContext3DImpl::texParameteri(
WGC3Denum target, WGC3Denum pname, WGC3Dint param) {
- // TODO(kbr): figure out whether the setting of TEXTURE_WRAP_R in
legend 2015/05/11 07:17:14 @kbr and others, i'm not sure if this comment and
piman 2015/05/11 21:39:34 FYI on ES, cube maps are always seamless regardles
Zhenyao Mo 2015/05/11 23:23:44 Yes, remove it.
- // GraphicsContext3D.cpp is strictly necessary to avoid seams at the
- // edge of cube maps, and, if it is, push it into the GLES2 service
- // side code.
- if (pname == kTextureWrapR) {
- return;
- }
gl_->TexParameteri(target, pname, param);
}
« no previous file with comments | « no previous file | gpu/command_buffer/build_gles2_cmd_buffer.py » ('j') | gpu/command_buffer/build_gles2_cmd_buffer.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698