Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1133013002: Improve parsing manifest for FSP API. (Closed)

Created:
5 years, 7 months ago by mtomasz
Modified:
5 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, not at google - send to devlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve parsing manifest for FSP API. This CL makes the FSP section a prerequisite for the permission. It also adds a warning if a section is used without a permission. TEST=unit_tests: *FileSystemProviderHandlerTest*" BUG=474146 Committed: https://crrev.com/8f7d2587e27589c1d0bddeb3f6de9c50aad6829e Cr-Commit-Position: refs/heads/master@{#329374}

Patch Set 1 #

Patch Set 2 : Fixed tests. #

Patch Set 3 : Fixed tests. #

Patch Set 4 : Fixed tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -4 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/api/file_system_provider/file_system_provider_handler_unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc View 1 3 chunks +28 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/add_watcher/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/big_file/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/copy_entry/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/create_directory/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/create_file/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/delete_entry/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/evil/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/extension/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_all/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_metadata/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mime_type/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/move_entry/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/notify/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_directory/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_file/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/remove_watcher/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/thumbnail/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/truncate/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/unmount/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/write_file/manifest.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/filesystemprovider_missing_capabilities.json View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/extensions/manifest_tests/filesystemprovider_missing_permission.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/filesystemprovider_valid.json View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M extensions/common/manifest_constants.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/manifest_constants.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
mtomasz
@benwells: PTAL. Thanks. @kalman: FYI.
5 years, 7 months ago (2015-05-11 04:39:46 UTC) #2
benwells
lgtm
5 years, 7 months ago (2015-05-11 07:28:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133013002/1
5 years, 7 months ago (2015-05-11 07:29:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/16314)
5 years, 7 months ago (2015-05-11 09:26:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133013002/20001
5 years, 7 months ago (2015-05-12 03:26:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/16800)
5 years, 7 months ago (2015-05-12 04:26:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133013002/40001
5 years, 7 months ago (2015-05-12 06:04:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/16834)
5 years, 7 months ago (2015-05-12 07:04:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133013002/60001
5 years, 7 months ago (2015-05-12 07:15:37 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-12 08:21:34 UTC) #21
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 08:22:22 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8f7d2587e27589c1d0bddeb3f6de9c50aad6829e
Cr-Commit-Position: refs/heads/master@{#329374}

Powered by Google App Engine
This is Rietveld 408576698