tools/profile_chrome/perf_controller.py - Issue 1132993004: [Android] Remove more references to and uses of AndroidCommands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/profile_chrome/perf_controller.py

Issue 1132993004: [Android] Remove more references to and uses of AndroidCommands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/profile_chrome/perf_controller.py

diff --git a/tools/profile_chrome/perf_controller.py b/tools/profile_chrome/perf_controller.py

index 06992cfd134bfb3ba9de1f099418492db80de3c3..bd979d59c37d195fd095eaec511d9807dc6ec0d5 100644

--- a/tools/profile_chrome/perf_controller.py

+++ b/tools/profile_chrome/perf_controller.py

@@ -15,6 +15,7 @@ from profile_chrome import ui

from pylib import android_commands

from pylib import constants

from pylib.perf import perf_control

+from pylib.utils import device_temp_file

sys.path.append(os.path.join(constants.DIR_SOURCE_ROOT,

'tools',

@@ -47,8 +48,8 @@ _PERF_OPTIONS = [

class _PerfProfiler(object):

def __init__(self, device, perf_binary, categories):

self._device = device

- self._output_file = android_commands.DeviceTempFile(

- self._device.old_interface, prefix='perf_output')

+ self._output_file = device_temp_file.DeviceTempFile(

+ self._device.adb, prefix='perf_output')

self._log_file = tempfile.TemporaryFile()

# TODO(jbudorick) Look at providing a way to unhandroll this once the

« no previous file with comments | « tools/profile_chrome/main.py ('k') | tools/profile_chrome_startup.py » ('j') | no next file with comments »