tools/profile_chrome/controllers_unittest.py - Issue 1132993004: [Android] Remove more references to and uses of AndroidCommands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/profile_chrome/controllers_unittest.py

Issue 1132993004: [Android] Remove more references to and uses of AndroidCommands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/profile_chrome/controllers_unittest.py

diff --git a/tools/profile_chrome/controllers_unittest.py b/tools/profile_chrome/controllers_unittest.py

index 1d9a10ca84d90c0c501a6af0560e169a71298ee4..3b18bd02010590f6d72ed371a012efeb44a530f9 100644

--- a/tools/profile_chrome/controllers_unittest.py

+++ b/tools/profile_chrome/controllers_unittest.py

@@ -6,19 +6,18 @@ import unittest

from profile_chrome import profiler

-from pylib import android_commands

from pylib.device import device_utils

from pylib.device import intent

class BaseControllerTest(unittest.TestCase):

def setUp(self):

- devices = android_commands.GetAttachedDevices()

+ devices = device_utils.DeviceUtils.HealthyDevices()

self.browser = 'stable'

self.package_info = profiler.GetSupportedBrowsers()[self.browser]

self.device = device_utils.DeviceUtils(devices[0])

Sami 2015/05/12 18:37:09 Should the DeviceUtils part be removed here?

jbudorick 2015/05/13 03:21:22 Yes, done.

- self.device.old_interface.CloseApplication(self.package_info.package)

+ self.device.ForceStop(self.package_info.package)

self.device.StartActivity(

intent.Intent(activity=self.package_info.activity,

package=self.package_info.package),

« no previous file with comments | « tools/cygprofile/profile_android_startup.py ('k') | tools/profile_chrome/main.py » ('j') | tools/profile_chrome/main.py » ('J')