Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1132983005: Show guest button based on extension parameter guestSignin. (Closed)

Created:
5 years, 7 months ago by achuithb
Modified:
5 years, 7 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show guest button based on extension parameter guestSignin. BUG=487474 TEST=manual Committed: https://crrev.com/f936368ab5d09e2a63822961e7324096bcb67eeb Cr-Commit-Position: refs/heads/master@{#329812}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
achuithb
Pavel, Alex, please take a look.
5 years, 7 months ago (2015-05-13 23:36:06 UTC) #2
Nikita (slow)
lgtm
5 years, 7 months ago (2015-05-14 05:54:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132983005/20001
5 years, 7 months ago (2015-05-14 05:54:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 06:32:22 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 06:33:15 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f936368ab5d09e2a63822961e7324096bcb67eeb
Cr-Commit-Position: refs/heads/master@{#329812}

Powered by Google App Engine
This is Rietveld 408576698