Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1132973002: Revert of Added stub MediaSourcePlayer for developing behind the flag (Closed)

Created:
5 years, 7 months ago by miu
Modified:
5 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added stub MediaSourcePlayer for developing behind the flag (patchset #13 id:240001 of https://codereview.chromium.org/1076013002/) Reason for revert: Broke Android Clang Builder (dbg): http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Clang%20Builder%20%28dbg%29&number=59307 Original issue's description: > Added stub MediaSourcePlayer for developing behind the flag > > Added a new experimental flag and stub implementation for > the player. Created Media thread and redirected demuxer > messages to it. > > BUG=none > > Committed: https://crrev.com/8ad68b12db7db320a37e39e94be8d45205fee626 > Cr-Commit-Position: refs/heads/master@{#329059} TBR=qinmin@chromium.org,timav@google.com,xhwang@chromium.org,sievers@chromium.org,timav@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/9160c54f557035f966bed567e1bb7950d1479162 Cr-Commit-Position: refs/heads/master@{#329061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -446 lines) Patch
M content/browser/media/android/browser_demuxer_android.h View 3 chunks +2 lines, -14 lines 0 comments Download
M content/browser/media/android/browser_demuxer_android.cc View 4 chunks +6 lines, -45 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 4 chunks +8 lines, -27 lines 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D media/base/android/media_codec_player.h View 1 chunk +0 lines, -85 lines 0 comments Download
D media/base/android/media_codec_player.cc View 1 chunk +0 lines, -252 lines 0 comments Download
M media/base/android/media_player_android.h View 2 chunks +0 lines, -9 lines 0 comments Download
M media/base/android/media_player_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
miu
Created Revert of Added stub MediaSourcePlayer for developing behind the flag
5 years, 7 months ago (2015-05-10 01:37:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132973002/1
5 years, 7 months ago (2015-05-10 01:37:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-10 01:40:05 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-10 01:41:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9160c54f557035f966bed567e1bb7950d1479162
Cr-Commit-Position: refs/heads/master@{#329061}

Powered by Google App Engine
This is Rietveld 408576698