content/browser/accessibility/browser_accessibility_win.cc - Issue 1132963002: Handles conversion rule for TimeRole and updates InputTimeRole.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 1132963002: Handles conversion rule for TimeRole and updates InputTimeRole. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/renderer/accessibility/blink_ax_enum_conversion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index 74994bd94aa4882f768d713dd2bfa72dc3f247d5..67e9641b1d808e90792cfaba9462ee15a98ba0d9 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -4070,6 +4070,9 @@ void BrowserAccessibilityWin::InitRoleAndState() {

ia_state |= STATE_SYSTEM_LINKED;

ia_state |= STATE_SYSTEM_READONLY;

break;

+ case ui::AX_ROLE_INPUT_TIME:

+ ia_role = ROLE_SYSTEM_SPINBUTTON;

dmazzoni 2015/05/10 06:33:07 This probably isn't right anymore. Back when I add

je_julie(Not used) 2015/05/21 02:25:17 Thanks for your comment. I found it's mapped to RO

+ break;

case ui::AX_ROLE_LABEL_TEXT:

case ui::AX_ROLE_LEGEND:

ia_role = ROLE_SYSTEM_TEXT;

@@ -4284,7 +4287,8 @@ void BrowserAccessibilityWin::InitRoleAndState() {

ia2_state |= IA2_STATE_SELECTABLE_TEXT;

break;

case ui::AX_ROLE_TIME:

- ia_role = ROLE_SYSTEM_SPINBUTTON;

+ ia_role = ROLE_SYSTEM_TEXT;

+ ia2_role = IA2_ROLE_TEXT_FRAME;

break;

case ui::AX_ROLE_TIMER:

ia_role = ROLE_SYSTEM_CLOCK;