Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1132943007: Fixed various simulator-related space leaks. (Closed)

Created:
5 years, 7 months ago by Sven Panne
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixed various simulator-related space leaks. Alas, this involved quite a bit of copy-n-paste between the architectures, but this is caused by the very convoluted relationships, lifetimes and distribution of responsibilities. This should really be cleaned up by moving code around and using STL maps, but that's not really a priority right now. Bonus: Fixed leaks in the ARM64 disassembler tests. Committed: https://crrev.com/84aa494ebcbf8f55758cbc8c79740290fdbda8ae Cr-Commit-Position: refs/heads/master@{#28496}

Patch Set 1 #

Patch Set 2 : Delete i_cache only once #

Patch Set 3 : Fixed a leak in ARM64 disassembler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -11 lines) Patch
M src/arm/simulator-arm.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 3 chunks +22 lines, -2 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 3 chunks +22 lines, -2 lines 0 comments Download
M src/mips64/simulator-mips64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 3 chunks +22 lines, -2 lines 0 comments Download
M src/ppc/simulator-ppc.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 1 3 chunks +22 lines, -1 line 0 comments Download
M test/cctest/test-disasm-arm64.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
This should fix the problems encountered while trying to debug chromium:489006...
5 years, 7 months ago (2015-05-19 09:19:38 UTC) #2
Hannes Payer (out of office)
On 2015/05/19 09:19:38, Sven Panne wrote: > This should fix the problems encountered while trying ...
5 years, 7 months ago (2015-05-19 15:05:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132943007/40001
5 years, 7 months ago (2015-05-20 05:55:03 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 05:56:12 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 05:56:23 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/84aa494ebcbf8f55758cbc8c79740290fdbda8ae
Cr-Commit-Position: refs/heads/master@{#28496}

Powered by Google App Engine
This is Rietveld 408576698