Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1132943003: Deflake MultiThreadedProxyResolverTest.ThreeThreads_Basic. (Closed)

Created:
5 years, 7 months ago by Sam McNally
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake MultiThreadedProxyResolverTest.ThreeThreads_Basic. Previously, MultiThreadedProxyResolverTest.ThreeThreads_Basic started multiple requests in parallel and expected resolvers on three threads to be created and used. However, the new resolver thread can take long enough to become ready that it doesn't finish initializing its resolver before all requests complete on other threads and the test finishes. This CL fixes this by blocking the resolvers to force requests to run on new resolver threads. BUG=486257 Committed: https://crrev.com/3418083e501f3bf267508563b3f1762c1f22d5e3 Cr-Commit-Position: refs/heads/master@{#329360}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -38 lines) Patch
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 3 chunks +61 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam McNally
5 years, 7 months ago (2015-05-11 08:22:50 UTC) #3
eroman
lgtm
5 years, 7 months ago (2015-05-12 05:26:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132943003/20001
5 years, 7 months ago (2015-05-12 05:59:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-12 06:04:24 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 06:05:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3418083e501f3bf267508563b3f1762c1f22d5e3
Cr-Commit-Position: refs/heads/master@{#329360}

Powered by Google App Engine
This is Rietveld 408576698