bluetooth: Move mock creation out of BluetoothDispatcherHost to LayoutTestBluetoothAdapterProvider.

content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_
+#define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_
+
+#include "base/callback.h"
+#include "device/bluetooth/bluetooth_adapter.h"
+#include "device/bluetooth/bluetooth_adapter_factory.h"
+#include "device/bluetooth/bluetooth_device.h"
+#include "device/bluetooth/bluetooth_uuid.h"
+#include "device/bluetooth/test/mock_bluetooth_adapter.h"
+#include "device/bluetooth/test/mock_bluetooth_device.h"
+#include "device/bluetooth/test/mock_bluetooth_discovery_session.h"
+
+namespace content {
+
+using device::BluetoothAdapter;
+using device::BluetoothAdapterFactory;
+using device::BluetoothDevice;
+using device::BluetoothDiscoverySession;
+using device::BluetoothUUID;
+using device::MockBluetoothAdapter;
+using device::MockBluetoothDevice;
+using device::MockBluetoothDiscoverySession;
+
+class LayoutTestBluetoothAdapterProvider {

[scheib, 2015/05/11 20:19:26]

Class comment, along the lines of:
Implements fake adapters with named mock data sets for use in tests as a result
of layout tests calling testRunner.setBluetoothMockDataSet.

[ortuno, 2015/05/12 19:33:20]

Done.

+ public:
+  LayoutTestBluetoothAdapterProvider();
+  ~LayoutTestBluetoothAdapterProvider();
+  void GetBluetoothAdapter(

[scheib, 2015/05/11 20:19:26]

Same comment as used in BrowserContext.

[ortuno, 2015/05/12 19:33:20]

Done.

+      const base::Callback<
+          void(scoped_refptr<device::BluetoothAdapter> adapter)>& callback,
+      const std::string& adapter);
+
+ protected:
+  scoped_ptr<testing::NiceMock<MockBluetoothDevice>> empty_device_;
+
+ private:

[scheib, 2015/05/12 01:16:28]

We can leave everything in protected, move the data member down to reduce
sections.

[ortuno, 2015/05/12 19:33:20]

Done.

+  /*

[scheib, 2015/05/11 20:19:26]

Use // comment style for consistency. Though /* */ is style compliant it's not
used in chromium code.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Comment_Style

[scheib, 2015/05/12 01:16:28]

Lead these comment blocks with the fake_adapter_name identifier string,
something like;

// Provides "EmptyAdapter" fake BluetoothAdapter to |callback| with the
// following characteristics:
// ...

[ortuno, 2015/05/12 19:33:20]

Done.

+    Calls |callback| with a BluetoothAdapter with the following
+    characteristics:
+     - |StartDiscoverySession| invokes |SuccessfulDiscoverySession|

[scheib, 2015/05/11 20:19:26]

Add periods to all sentence fragments comments in this file.

[ortuno, 2015/05/12 19:33:20]

Done.

+     - |GetDevices| returns an empty list of devices
+  */
+  void GetEmptyAdapter(
+      const BluetoothAdapterFactory::AdapterCallback& callback);
+  /*
+    Calls |callback| with a BluetoothAdapter with the following
+    characteristics:
+     - |StartDiscoverySession| invokes |SuccessfulDiscoverySessionCallback|
+     - |GetDevices| returns an list with an |Empty Device|

[scheib, 2015/05/11 20:19:26]

"returns a list".

[scheib, 2015/05/12 01:16:28]

In the fake adapter names you've gone with a CamelCase name identifier, do the
same with EmptyDevice for consistency.

[ortuno, 2015/05/12 19:33:20]

Done.

+  */
+  void GetSingleEmptyDeviceAdapter(
+      const BluetoothAdapterFactory::AdapterCallback& callback);
+
+  /*
+    Calls |callback| with a DiscoverySession with the following
+    characteristics:
+     - |Stop| will invoke |SuccessfulStopDiscoverySession|
+  */
+  void SuccessfulDiscoverySessionCallback(

[scheib, 2015/05/12 01:16:28]

How about just "SuccessfulDiscoverySession".

[ortuno, 2015/05/12 19:33:20]

Done.

+      const BluetoothAdapter::DiscoverySessionCallback& callback,
+      const BluetoothAdapter::ErrorCallback& error_callback);
+
+  // Calls |callback|

[scheib, 2015/05/12 01:16:28]

Just merge this method up to be covered by previous method comment. Rename
SuccessfulDiscoverySessionStop.

[ortuno, 2015/05/12 19:33:20]

Done.

+  static void SuccessfulStopDiscoverySessionCallback(
+      const base::Closure& callback,
+      const base::Closure& error_callback);
+  /*
+    Sets up an |Empty Device| with the following characeteristics:
+     - |GetAddress| returns "Empty Mock Device instanceID"
+     - |GetName| returns "Empty Mock Device name"
+     - |GetBluetoothClass| returns |kUnspecifiedDeviceClass|
+     - |GetVendorIDSource| returns |BluetoothDevice::VENDOR_ID_BLUETOOTH|
+     - |GetVendorID| returns |0xFFFF|
+     - |GetProductID| returns 1
+     - |GetDeviceID| returns 2
+     - |IsPaired| returns true
+     - |GetUUIDs| returns a list with two UUIDs: |uuid1| and |uuid2|

[scheib, 2015/05/11 20:19:26]

I like these method docs. At some point we'll move test data into the spec (or
an companion spec) and from here want to reference that and probably copy text
in a similar way to how we write that up. That text will need to contain all
information about how the fake data set will behave, so I'd like to have all
literal values exist in either comments here or in literal values declared in
this file.

In cases where one-off literal values are used, we should document the value
"1F00" meaning "Unspecified Device Class".

If values are being used multiple times, let's move them to constants declared
in this file e.g. LayoutTestBluetoothAdapterProvider::kUnspecifiedDeviceClass. I
think it's OK to provide the value definition in this header when possible as
well to have improved readability of what the test data sets are without the
indirection of going to the cc file.

[ortuno, 2015/05/12 19:33:20]

Moved everything inline since we aren't using anything more than once. As I
write more tests I will turn them into constants.

+  */
+  void SetUpMockEmptyDevice(MockBluetoothAdapter* adapter);

[scheib, 2015/05/11 20:19:26]

Everything is a mock in this class, and 'Setup' is a word, so let's just use
SetupEmptyDevice.
Insert empty line after method and data members.

[ortuno, 2015/05/12 19:33:20]

Done.

+  scoped_ptr<BluetoothUUID> uuid1;

[scheib, 2015/05/11 20:19:26]

FYI Naming style of members has an underscore suffix, but: No need to have the
UUIDs be member variables I think, just push_back(BluetoothUUID("1234")).

[ortuno, 2015/05/12 19:33:20]

Done.

+  scoped_ptr<BluetoothUUID> uuid2;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_