Handle re-issued cards in unmasking prompt.

Handle re-issued cards in unmasking prompt.

BUG=487866
Committed: https://crrev.com/ea92359618ea92a2d5700d9938c7a48de0c6de38
Cr-Commit-Position: refs/heads/master@{#329982}

[Evan Stade, 2015-05-14 21:33:08]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2015-05-14 21:33:08]

+sky for review
+jdonnelly, bondd FYI

[sky, 2015-05-14 22:05:59]

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
File chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc (right):

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:147: for (int i =
0; i < input_row_->child_count(); ++i) {
nit: no {}

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:151:
input_row_->InvalidateLayout();
I don't see an explicit layout anywhere. Who triggers it?

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:192: new_card_link_
= new views::Link(
I assume you can never hit this more than once, right?

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:424: for (int i =
0; i < input_row_->child_count(); ++i) {
nit: no {}

[Evan Stade, 2015-05-14 22:38:23]

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
File chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc (right):

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:147: for (int i =
0; i < input_row_->child_count(); ++i) {
On 2015/05/14 22:05:59, sky wrote:
> nit: no {}

Done.

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:151:
input_row_->InvalidateLayout();
On 2015/05/14 22:05:59, sky wrote:
> I don't see an explicit layout anywhere. Who triggers it?

see ^ below

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:180: Layout();
^

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:192: new_card_link_
= new views::Link(
On 2015/05/14 22:05:59, sky wrote:
> I assume you can never hit this more than once, right?

Yes, that's the case, but it is still a pretty fragile assumption. Fixed.

https://codereview.chromium.org/1132933004/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:424: for (int i =
0; i < input_row_->child_count(); ++i) {
On 2015/05/14 22:05:59, sky wrote:
> nit: no {}

Done.

[sky, 2015-05-14 22:48:04]

LGTM

[Evan Stade, 2015-05-14 23:12:59]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-05-14 23:12:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1132933004/#ps20001
(title: "sky review")

[commit-bot: I haz the power, 2015-05-14 23:14:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132933004/20001

[commit-bot: I haz the power, 2015-05-15 00:07:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-15 00:08:35]

Patchset 2 (id:??) landed as
https://crrev.com/ea92359618ea92a2d5700d9938c7a48de0c6de38
Cr-Commit-Position: refs/heads/master@{#329982}