Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1132933003: [es6] support spread-calling Super-accessing properties (Closed)

Created:
5 years, 7 months ago by caitp (gmail)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] support spread-calling Super-accessing properties BUG=v8:4105, v8:3018 LOG=N R=arv@chromium.org Committed: https://crrev.com/3a18b9b71bac2f64db3dcbef6e2a503262036c1c Cr-Commit-Position: refs/heads/master@{#28405}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -11 lines) Patch
M src/parser.cc View 1 chunk +19 lines, -11 lines 1 comment Download
A test/mjsunit/harmony/spread-call-super-property.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
caitp (gmail)
PTAL, this ones pretty tiny
5 years, 7 months ago (2015-05-14 21:12:22 UTC) #1
arv (Not doing code reviews)
LGTM That was fast. https://codereview.chromium.org/1132933003/diff/20001/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/1132933003/diff/20001/src/parser.cc#newcode5714 src/parser.cc:5714: VariableProxy* home = factory()->NewVariableProxy(original_home->var()); It ...
5 years, 7 months ago (2015-05-14 21:54:56 UTC) #3
caitp (gmail)
On 2015/05/14 21:54:56, arv wrote: > LGTM > > That was fast. > > https://codereview.chromium.org/1132933003/diff/20001/src/parser.cc ...
5 years, 7 months ago (2015-05-14 22:01:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132933003/20001
5 years, 7 months ago (2015-05-14 22:22:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-14 22:59:29 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 22:59:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a18b9b71bac2f64db3dcbef6e2a503262036c1c
Cr-Commit-Position: refs/heads/master@{#28405}

Powered by Google App Engine
This is Rietveld 408576698