Chromium Code Reviews

Unified Diff: git_cl.py

Issue 1132913005: Make buildbucket default for git cl try (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index f3aa2ab5ae972872605c01d26bfa22e1f742a101..a7aec86f4bd6b1d140910701ed658810477f1141 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -2859,7 +2859,8 @@ def CMDtree(parser, args):
def CMDtry(parser, args):
- """Triggers a try job through Rietveld."""
+ """Triggers a try job through BuildBucket."""
+ parser.set_defaults(buildbucket=True)
group = optparse.OptionGroup(parser, "Try job options")
group.add_option(
"-b", "--bot", action="append",
@@ -2887,8 +2888,11 @@ def CMDtry(parser, args):
group.add_option(
"-n", "--name", help="Try job name; default to current branch name")
group.add_option(
- "--use-buildbucket", action="store_true", default=False,
+ "--use-buildbucket", dest='buildbucket', action="store_true",
help="Use buildbucket to trigger try jobs.")
+ group.add_option(
+ "--nouse-buildbucket", dest='buildbucket', action="store_false",
nodir 2015/07/15 21:22:14 Why do you need both options?
sheyang 2015/07/16 17:29:49 Don't remember, probably just want to preserve "--
+ help="Use Rietveld to trigger try jobs.")
parser.add_option_group(group)
auth.add_auth_options(parser)
options, args = parser.parse_args(args)
@@ -2986,7 +2990,7 @@ def CMDtry(parser, args):
'\nWARNING Mismatch between local config and server. Did a previous '
'upload fail?\ngit-cl try always uses latest patchset from rietveld. '
'Continuing using\npatchset %s.\n' % patchset)
- if options.use_buildbucket:
+ if options.buildbucket:
try:
trigger_try_jobs(auth_config, cl, options, masters, 'git_cl_try')
except BuildbucketResponseException as ex:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine