Make buildbucket default for git cl try

Make buildbucket default for git cl try

BUG=461614
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296339

[nodir, 2015-07-15 21:22:14]

nodir@chromium.org changed reviewers:
+ nodir@chromium.org

[nodir, 2015-07-15 21:22:14]

https://codereview.chromium.org/1132913005/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1132913005/diff/1/git_cl.py#newcode69
git_cl.py:69: BUILDBUCKET_HOST = 'cr-buildbucket.appspot.com'
Please make this configurable via an option

https://codereview.chromium.org/1132913005/diff/1/git_cl.py#newcode2894
git_cl.py:2894: "--nouse-buildbucket", dest='buildbucket', action="store_false",
Why do you need both options?

[sheyang, 2015-07-16 17:29:49]

https://codereview.chromium.org/1132913005/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1132913005/diff/1/git_cl.py#newcode69
git_cl.py:69: BUILDBUCKET_HOST = 'cr-buildbucket.appspot.com'
On 2015/07/15 21:22:14, nodir wrote:
> Please make this configurable via an option

Done.

https://codereview.chromium.org/1132913005/diff/1/git_cl.py#newcode2894
git_cl.py:2894: "--nouse-buildbucket", dest='buildbucket', action="store_false",
On 2015/07/15 21:22:14, nodir wrote:
> Why do you need both options?

Don't remember, probably just want to preserve "--use-buildbucket".

Removed.

[nodir, 2015-07-16 18:20:01]

Thank you! This lgtm % option name. I will let you know when this can be
committed

https://codereview.chromium.org/1132913005/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1132913005/diff/20001/git_cl.py#newcode3078
git_cl.py:3078: "--nouse-buildbucket", action="store_true", default=False,
Please rename to --use-rietveld

[nodir, 2015-07-16 18:21:22]

I set NO_COMMIT

[sheyang, 2015-07-16 18:39:45]

https://codereview.chromium.org/1132913005/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1132913005/diff/20001/git_cl.py#newcode3078
git_cl.py:3078: "--nouse-buildbucket", action="store_true", default=False,
On 2015/07/16 18:20:00, nodir wrote:
> Please rename to --use-rietveld

Done.

[nodir, 2015-07-16 19:48:31]

lgtm

[sheyang, 2015-08-17 19:20:12]

The CQ bit was checked by sheyang@chromium.org

[commit-bot: I haz the power, 2015-08-17 19:20:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132913005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1132913005/40001

[commit-bot: I haz the power, 2015-08-17 19:22:28]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296339