Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Unified Diff: chrome/browser/media/router/media_source_helper.cc

Issue 1132903002: [MediaRouter] Add implementation of PresentationServiceDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_source_helper.cc
diff --git a/chrome/browser/media/router/media_source_helper.cc b/chrome/browser/media/router/media_source_helper.cc
index 305a00fa3437dd83fa5b8eba3de0bdb61e65380c..1db6661a23f0cea16802bbe6380f9081c66b8e91 100644
--- a/chrome/browser/media/router/media_source_helper.cc
+++ b/chrome/browser/media/router/media_source_helper.cc
@@ -26,7 +26,7 @@ MediaSource ForDesktopMediaSource() {
}
// TODO(mfoltz): Remove when the TODO in
-// MediaSourceManager::GetDefaultMediaSource is resolved.
+// PresentationServiceDelegateImpl::default_source is resolved.
Wez 2015/05/27 22:37:49 What does it mean for it to be "resolved..? Can yo
haibinlu 2015/05/28 21:44:02 comment removed. outdated TODO.
MediaSource ForCastAppMediaSource(const std::string& app_id) {
return MediaSource(kCastUrnPrefix + app_id);
}
@@ -49,4 +49,8 @@ bool IsValidMediaSource(const MediaSource& source) {
return url.is_valid() && url.SchemeIsHTTPOrHTTPS();
}
+std::string GetPresentationUrl(const MediaSource& source) {
Wez 2015/05/27 22:37:49 As per naming comment above, assuming you choose M
haibinlu 2015/05/28 21:44:01 Done.
+ return IsValidPresentationUrl(source.id()) ? source.id() : "";
+}
+
} // namespace media_router

Powered by Google App Engine
This is Rietveld 408576698