Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1132883003: Change a build-attribute REQUIRES check to use supported not requested. (Closed)

Created:
5 years, 7 months ago by jvoung (off chromium)
Modified:
5 years, 7 months ago
Reviewers:
Karl, Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change a build-attribute REQUIRES check to use supported not requested. Previously it would print both the targets compiled-in and the target requested on the commandline, but we really only care about what's compiled-in. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=33492e7603a11fab7ecf4ad471ce2a30557cd787

Patch Set 1 #

Total comments: 3

Patch Set 2 : move comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/IceCompiler.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/addr-opt-multi-def-var.ll View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jvoung (off chromium)
5 years, 7 months ago (2015-05-15 22:28:11 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1132883003/diff/1/src/IceCompiler.cpp File src/IceCompiler.cpp (right): https://codereview.chromium.org/1132883003/diff/1/src/IceCompiler.cpp#newcode51 src/IceCompiler.cpp:51: // List the supported targets. This comment's indentation ...
5 years, 7 months ago (2015-05-15 23:21:51 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/1132883003/diff/1/src/IceCompiler.cpp File src/IceCompiler.cpp (right): https://codereview.chromium.org/1132883003/diff/1/src/IceCompiler.cpp#newcode51 src/IceCompiler.cpp:51: // List the supported targets. On 2015/05/15 23:21:50, stichnot ...
5 years, 7 months ago (2015-05-15 23:50:30 UTC) #4
Jim Stichnoth
https://codereview.chromium.org/1132883003/diff/1/src/IceCompiler.cpp File src/IceCompiler.cpp (right): https://codereview.chromium.org/1132883003/diff/1/src/IceCompiler.cpp#newcode51 src/IceCompiler.cpp:51: // List the supported targets. On 2015/05/15 23:50:30, jvoung ...
5 years, 7 months ago (2015-05-15 23:52:06 UTC) #5
jvoung (off chromium)
5 years, 7 months ago (2015-05-16 00:02:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
33492e7603a11fab7ecf4ad471ce2a30557cd787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698