Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1132873009: Remove app_installer code. (Closed)

Created:
5 years, 7 months ago by jackhou1
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove app_installer code. This has been cancelled for a while. BUG=341353 Committed: https://crrev.com/daebca577af59c02c98f8d9e20cabefa7a3ad74a Cr-Commit-Position: refs/heads/master@{#331258}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -859 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M build/all.gyp View 3 chunks +0 lines, -4 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/app_installer/BUILD.gn View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/app_installer/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/app_installer/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/app_installer/app_installer.gypi View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/app_installer/win/app_installer.exe.manifest View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/app_installer/win/app_installer_main.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/app_installer/win/app_installer_util.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/app_installer/win/app_installer_util.cc View 1 chunk +0 lines, -376 lines 0 comments Download
D chrome/app_installer/win/app_installer_util_unittest.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -11 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
jam, could you take a look? This touches a bunch of files, all to remove ...
5 years, 7 months ago (2015-05-22 01:05:19 UTC) #2
jam
lgtm
5 years, 7 months ago (2015-05-22 14:48:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132873009/20001
5 years, 7 months ago (2015-05-25 03:27:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-25 04:50:01 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 04:50:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/daebca577af59c02c98f8d9e20cabefa7a3ad74a
Cr-Commit-Position: refs/heads/master@{#331258}

Powered by Google App Engine
This is Rietveld 408576698