do not hardcode -I/usr/include32 when cross-compiling

do not hardcode -I/usr/include32 when cross-compiling

When we cross-compile, we do not want any /usr/include paths as that will
conflict with our own system headers.  Disable the hardcoded path when we
have an active sysroot.

BUG=chromium:488360
Committed: https://crrev.com/58b42a0c48127c60baad7ea79ea0e5576c6e1d0b
Cr-Commit-Position: refs/heads/master@{#330514}

[vapier, 2015-05-16 02:08:20]

vapier@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2015-05-19 08:49:57]

LGTM

[vapier, 2015-05-19 09:12:05]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2015-05-19 09:12:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132853010/1

[commit-bot: I haz the power, 2015-05-19 09:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 09:18:12]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vapier, 2015-05-19 09:23:47]

vapier@chromium.org changed reviewers:
+ cjhopman@chromium.org, dpranke@chromium.org, jochen@chromium.org,
scottmg@chromium.org, thakis@chromium.org

[jochen (gone - plz use gerrit), 2015-05-19 11:29:38]

lgtm

[vapier, 2015-05-19 12:31:23]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2015-05-19 12:31:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132853010/1

[commit-bot: I haz the power, 2015-05-19 13:24:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-19 13:25:39]

Patchset 1 (id:??) landed as
https://crrev.com/58b42a0c48127c60baad7ea79ea0e5576c6e1d0b
Cr-Commit-Position: refs/heads/master@{#330514}

[Sam Clegg, 2015-05-19 22:53:29]

On 2015/05/19 13:25:39, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/58b42a0c48127c60baad7ea79ea0e5576c6e1d0b
> Cr-Commit-Position: refs/heads/master@{#330514}

This doesn't seem to work for me:

$ GYP_DEFINES=target_arch=ia32 build/gyp_chromium
Updating projects from gyp files...
gyp: name 'use_sysroot' is not defined while evaluating condition
'host_arch!="ia32" and OS!="android" and use_sysroot!=1' in
/home/sbc/dev/chromium/src/build/all.gyp


Also, I'm not sure it doesn't what you think it does.  The use_sysroot=1 is way
to force the use of the sysroot but the sysroot is also used when building
"official" builder, even when use_sysroot is not yet.

Also, on what system is /usr/include32 even thing?  Even it it was thing, should
-m32 automatically add this.  On ubuntu/debian the path for such headers is
/usr/include/i386-linux-gnu/ and -m32 gives you this for free I think.

Can we just remove this block perhaps?

[hans, 2015-05-19 23:31:53]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1147793003/ by hans@chromium.org.

The reason for reverting is: Looks like this broke some builds, where
'use_sysroot' isn't defined. See http://crbug.com/489783.

Sounds like sbc has an alternative solution here:
https://codereview.chromium.org/1142793003/.