Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart

Issue 113283008: Use growable lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tests/lib/mirrors/mirrors_used_merge_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart b/dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart
index fad167e91a36f76264ec9dc9ebb0550fb115970d..6aacb9453c61b3ce4ca21ba9730cac2a71128cce 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart
@@ -461,7 +461,7 @@ class MirrorUsageBuilder {
assert(invariant(spannable, entry is String));
karlklose 2013/12/12 07:57:18 Why this invariant? Checked mode will already chec
ahe 2013/12/12 09:58:07 Checked mode doesn't know which AST node (or eleme
result[count++] = entry;
}
- return result;
+ return result.toList(growable: true);
karlklose 2013/12/12 10:27:49 'true' is the default.
ahe 2013/12/12 11:04:59 Yes. But I'm passing the value explicitly to docum
}
/// Convert a list of strings and types to a list of elements. Types are
« no previous file with comments | « no previous file | dart/tests/lib/mirrors/mirrors_used_merge_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698