Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1132823002: Added ServiceStatus string for State::kDownloaded. (Closed)

Created:
5 years, 7 months ago by Deepak
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added ServiceStatus string for State::kDownloaded. Downloaded was getting string for Updating, string added for Downloaded. BUG=486006 Committed: https://crrev.com/463d6c43ea5ceb77e8f0fba13970a3ecb5863d98 Cr-Commit-Position: refs/heads/master@{#329125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/components_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Deepak
PTAL
5 years, 7 months ago (2015-05-08 15:11:52 UTC) #2
Bernhard Bauer
+Sorin In principle this seems fine to me, but I'd like to let a component ...
5 years, 7 months ago (2015-05-08 15:16:07 UTC) #4
Sorin Jianu
lgtm Thank you!
5 years, 7 months ago (2015-05-08 16:53:31 UTC) #5
Bernhard Bauer
lgtm
5 years, 7 months ago (2015-05-09 10:56:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132823002/1
5 years, 7 months ago (2015-05-11 03:00:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 09:08:49 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 09:10:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/463d6c43ea5ceb77e8f0fba13970a3ecb5863d98
Cr-Commit-Position: refs/heads/master@{#329125}

Powered by Google App Engine
This is Rietveld 408576698