Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 1132793005: Update settings.html and settings.js to Polymer 0.8 (Closed)

Created:
5 years, 7 months ago by Jeremy Klein
Modified:
5 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update settings.html and settings.js to Polymer 0.8 BUG=485381 Committed: https://crrev.com/d548caa0a48298a075fe7482fb8a1f1b51f96be8 Cr-Commit-Position: refs/heads/master@{#329562}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adjust with new shared prefs_ property #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M chrome/browser/resources/settings/settings.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings.js View 1 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Jeremy Klein
5 years, 7 months ago (2015-05-13 00:14:48 UTC) #2
michaelpg
lgtm https://codereview.chromium.org/1132793005/diff/1/chrome/browser/resources/settings/settings.html File chrome/browser/resources/settings/settings.html (right): https://codereview.chromium.org/1132793005/diff/1/chrome/browser/resources/settings/settings.html#newcode8 chrome/browser/resources/settings/settings.html:8: <cr-settings-ui prefs="{{$.prefs}}"></cr-settings-ui> I've had problems with binding to ...
5 years, 7 months ago (2015-05-13 00:17:44 UTC) #3
Jeremy Klein
On 2015/05/13 00:17:44, michaelpg wrote: > lgtm > > https://codereview.chromium.org/1132793005/diff/1/chrome/browser/resources/settings/settings.html > File chrome/browser/resources/settings/settings.html (right): > ...
5 years, 7 months ago (2015-05-13 00:28:37 UTC) #4
michaelpg
SLGTM
5 years, 7 months ago (2015-05-13 00:38:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132793005/20001
5 years, 7 months ago (2015-05-13 00:51:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 01:50:34 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 01:52:13 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d548caa0a48298a075fe7482fb8a1f1b51f96be8
Cr-Commit-Position: refs/heads/master@{#329562}

Powered by Google App Engine
This is Rietveld 408576698