Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: media/blink/key_system_config_selector.cc

Issue 1132773003: Revert of Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/key_system_config_selector.h ('k') | media/blink/webcontentdecryptionmodule_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/key_system_config_selector.cc
diff --git a/media/blink/key_system_config_selector.cc b/media/blink/key_system_config_selector.cc
index 24cbf9f39dfd7dd13ddeccd20307f41f2a2ccece..f34bd8fc463cfb00ea9d5b3a1029653ae34805af 100644
--- a/media/blink/key_system_config_selector.cc
+++ b/media/blink/key_system_config_selector.cc
@@ -8,7 +8,6 @@
#include "base/logging.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
-#include "media/base/cdm_config.h"
#include "media/base/key_systems.h"
#include "media/base/media_permission.h"
#include "media/blink/webmediaplayer_util.h"
@@ -132,8 +131,8 @@
blink::WebVector<blink::WebMediaKeySystemConfiguration>
candidate_configurations;
blink::WebSecurityOrigin security_origin;
- base::Callback<void(const blink::WebMediaKeySystemConfiguration&,
- const CdmConfig&)> succeeded_cb;
+ base::Callback<void(const blink::WebMediaKeySystemConfiguration&, bool)>
+ succeeded_cb;
base::Callback<void(const blink::WebString&)> not_supported_cb;
bool was_permission_requested = false;
bool is_permission_granted = false;
@@ -159,8 +158,8 @@
bool IsIdentifierRecommended() const { return is_identifier_recommended_; }
- bool AreHwSecureCodecsRequired() const {
- return are_hw_secure_codecs_required_;
+ bool AreSecureCodecsRequired() const {
+ return are_secure_codecs_required_;
}
// Checks whether a rule is compatible with all previously added rules.
@@ -183,10 +182,10 @@
case EmeConfigRule::IDENTIFIER_AND_PERSISTENCE_REQUIRED:
return (!is_identifier_not_allowed_ && IsPermissionPossible() &&
!is_persistence_not_allowed_);
- case EmeConfigRule::HW_SECURE_CODECS_NOT_ALLOWED:
- return !are_hw_secure_codecs_required_;
- case EmeConfigRule::HW_SECURE_CODECS_REQUIRED:
- return !are_hw_secure_codecs_not_allowed_;
+ case EmeConfigRule::SECURE_CODECS_NOT_ALLOWED:
+ return !are_secure_codecs_required_;
+ case EmeConfigRule::SECURE_CODECS_REQUIRED:
+ return !are_secure_codecs_not_allowed_;
case EmeConfigRule::SUPPORTED:
return true;
}
@@ -220,11 +219,11 @@
is_identifier_required_ = true;
is_persistence_required_ = true;
return;
- case EmeConfigRule::HW_SECURE_CODECS_NOT_ALLOWED:
- are_hw_secure_codecs_not_allowed_ = true;
- return;
- case EmeConfigRule::HW_SECURE_CODECS_REQUIRED:
- are_hw_secure_codecs_required_ = true;
+ case EmeConfigRule::SECURE_CODECS_NOT_ALLOWED:
+ are_secure_codecs_not_allowed_ = true;
+ return;
+ case EmeConfigRule::SECURE_CODECS_REQUIRED:
+ are_secure_codecs_required_ = true;
return;
case EmeConfigRule::SUPPORTED:
return;
@@ -256,8 +255,8 @@
// Whether a rule has been added that requires or blocks hardware-secure
// codecs.
- bool are_hw_secure_codecs_required_ = false;
- bool are_hw_secure_codecs_not_allowed_ = false;
+ bool are_secure_codecs_required_ = false;
+ bool are_secure_codecs_not_allowed_ = false;
};
KeySystemConfigSelector::KeySystemConfigSelector(
@@ -674,8 +673,8 @@
candidate_configurations,
const blink::WebSecurityOrigin& security_origin,
bool are_secure_codecs_supported,
- base::Callback<void(const blink::WebMediaKeySystemConfiguration&,
- const CdmConfig&)> succeeded_cb,
+ base::Callback<void(const blink::WebMediaKeySystemConfiguration&, bool)>
+ succeeded_cb,
base::Callback<void(const blink::WebString&)> not_supported_cb) {
// Continued from requestMediaKeySystemAccess(), step 7, from
// https://w3c.github.io/encrypted-media/#requestmediakeysystemaccess
@@ -724,11 +723,10 @@
ConfigState config_state(request->was_permission_requested,
request->is_permission_granted);
DCHECK(config_state.IsRuleSupported(
- EmeConfigRule::HW_SECURE_CODECS_NOT_ALLOWED));
+ EmeConfigRule::SECURE_CODECS_NOT_ALLOWED));
if (!request->are_secure_codecs_supported)
- config_state.AddRule(EmeConfigRule::HW_SECURE_CODECS_NOT_ALLOWED);
+ config_state.AddRule(EmeConfigRule::SECURE_CODECS_NOT_ALLOWED);
blink::WebMediaKeySystemConfiguration accumulated_configuration;
- CdmConfig cdm_config;
ConfigurationSupport support = GetSupportedConfiguration(
request->key_system, request->candidate_configurations[i],
&config_state, &accumulated_configuration);
@@ -748,15 +746,8 @@
weak_factory_.GetWeakPtr(), base::Passed(&request)));
return;
case CONFIGURATION_SUPPORTED:
- cdm_config.allow_distinctive_identifier =
- (accumulated_configuration.distinctiveIdentifier ==
- blink::WebMediaKeySystemConfiguration::Requirement::Required);
- cdm_config.allow_persistent_state =
- (accumulated_configuration.persistentState ==
- blink::WebMediaKeySystemConfiguration::Requirement::Required);
- cdm_config.use_hw_secure_codecs =
- config_state.AreHwSecureCodecsRequired();
- request->succeeded_cb.Run(accumulated_configuration, cdm_config);
+ request->succeeded_cb.Run(accumulated_configuration,
+ config_state.AreSecureCodecsRequired());
return;
}
}
« no previous file with comments | « media/blink/key_system_config_selector.h ('k') | media/blink/webcontentdecryptionmodule_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698