Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1132773003: Revert of Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, eme-reviews_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, lcwu+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, gunsch+watch_chromium.org, wjia+watch_chromium.org, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid. (patchset #6 id:160001 of https://codereview.chromium.org/1131753003/) Reason for revert: Broke Linux GN clobber: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/258/steps/compile/logs/stdio Original issue's description: > Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid. > > This completes the path from the secure surface preference, through requestMediaKeySystemAccess() and finally to CDM creation on Android where secure codecs are enabled. With this change, configs requiring secure codes are rejected without the preference and the CDM is only configures to use hardware-secure codecs if the config requires it. > > There is a separate bug (http://crbug.com/478185) for implementing similar plumbing for the use of secure surfaces. > > BUG=467779 > > Committed: https://crrev.com/9ce0a551c7f1d79dea793b5691473ef9d5fb9326 > Cr-Commit-Position: refs/heads/master@{#330008} TBR=ddorwin@chromium.org,jrummell@chromium.org,gunsch@chromium.org,nasko@chromium.org,gunsch@google.com,sandersd@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467779 Committed: https://crrev.com/cd8c1af1fbdaf722ac3c855489282c0c0557d429 Cr-Commit-Position: refs/heads/master@{#330018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -198 lines) Patch
M chromecast/browser/media/cast_browser_cdm_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/media/cast_browser_cdm_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.h View 4 chunks +3 lines, -6 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 3 chunks +25 lines, -13 lines 0 comments Download
M content/common/media/cdm_messages.h View 2 chunks +3 lines, -8 lines 0 comments Download
M content/renderer/media/crypto/ppapi_decryptor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/ppapi_decryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/proxy_media_keys.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/media/crypto/proxy_media_keys.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/media/crypto/render_cdm_factory.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/media/crypto/render_cdm_factory.cc View 3 chunks +12 lines, -13 lines 0 comments Download
M content/renderer/media/crypto/renderer_cdm_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/crypto/renderer_cdm_manager.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M media/base/android/browser_cdm_factory_android.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/browser_cdm_factory_android.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M media/base/browser_cdm_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/browser_cdm_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D media/base/cdm_config.h View 1 chunk +0 lines, -29 lines 0 comments Download
M media/base/cdm_factory.h View 2 chunks +2 lines, -3 lines 0 comments Download
M media/base/eme_constants.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/key_systems.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/blink/cdm_session_adapter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/cdm_session_adapter.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/blink/key_system_config_selector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/key_system_config_selector.cc View 9 chunks +21 lines, -30 lines 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M media/blink/webcontentdecryptionmoduleaccess_impl.h View 3 chunks +5 lines, -9 lines 0 comments Download
M media/blink/webcontentdecryptionmoduleaccess_impl.cc View 3 chunks +24 lines, -12 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M media/cdm/default_cdm_factory.h View 2 chunks +2 lines, -3 lines 0 comments Download
M media/cdm/default_cdm_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cdm/proxy_decryptor.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid.
5 years, 7 months ago (2015-05-15 01:46:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132773003/1
5 years, 7 months ago (2015-05-15 01:47:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 01:50:43 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 01:51:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd8c1af1fbdaf722ac3c855489282c0c0557d429
Cr-Commit-Position: refs/heads/master@{#330018}

Powered by Google App Engine
This is Rietveld 408576698