Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1132773002: [turbofan] Don't try to push JSToNumber into phis early. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't try to push JSToNumber into phis early. This should not be done during typed lowering, but should be part of a dedicated truncation/conversion analysis. R=jarin@chromium.org Committed: https://crrev.com/225f9bf214494ba383adf8411d983ba38237e9e1 Cr-Commit-Position: refs/heads/master@{#28314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -94 lines) Patch
M src/compiler/js-typed-lowering.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 4 chunks +2 lines, -90 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-08 09:12:28 UTC) #1
Benedikt Meurer
Hey Jaro, This is the first CL on the typed array asm.js lowering fix that ...
5 years, 7 months ago (2015-05-08 09:13:17 UTC) #2
Jarin
lgtm
5 years, 7 months ago (2015-05-08 09:23:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132773002/1
5 years, 7 months ago (2015-05-08 09:24:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 09:35:04 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 09:35:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/225f9bf214494ba383adf8411d983ba38237e9e1
Cr-Commit-Position: refs/heads/master@{#28314}

Powered by Google App Engine
This is Rietveld 408576698