Source/core/css/StylePropertySerializer.h - Issue 1132753002: [CSS Grid Layout] Fix grid shorthands CSSOM serialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/StylePropertySerializer.h

Issue 1132753002: [CSS Grid Layout] Fix grid shorthands CSSOM serialization (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update test expectations for webexposed/nonstable-css-properties.html Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/StylePropertySerializer.h

diff --git a/Source/core/css/StylePropertySerializer.h b/Source/core/css/StylePropertySerializer.h

index 94059e070b7f2aa4012856ea83df89c5cf27b20e..76ea752cadba517d3af6ea9c80572f3ade9f2010 100644

--- a/Source/core/css/StylePropertySerializer.h

+++ b/Source/core/css/StylePropertySerializer.h

@@ -46,7 +46,7 @@ private:

String getLayeredShorthandValue(const StylePropertyShorthand&, bool checkShorthandAvailable = false) const;

String get4Values(const StylePropertyShorthand&) const;

String borderSpacingValue(const StylePropertyShorthand&) const;

- String getShorthandValue(const StylePropertyShorthand&) const;

+ String getShorthandValue(const StylePropertyShorthand&, String separator = " ") const;

String fontValue() const;

void appendFontLonghandValueIfExplicit(CSSPropertyID, StringBuilder& result, String& value) const;

String backgroundRepeatPropertyValue() const;

« no previous file with comments | « LayoutTests/webexposed/nonstable-css-properties-expected.txt ('k') | Source/core/css/StylePropertySerializer.cpp » ('j') | no next file with comments »