Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: test/win/gyptest-link-enable-winrt-app-revision.py

Issue 1132743006: Added msvs_application_type_revision for winrt compilation (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/win/gyptest-link-enable-winrt-app-revision.py
diff --git a/test/win/gyptest-link-enable-winrt.py b/test/win/gyptest-link-enable-winrt-app-revision.py
similarity index 61%
copy from test/win/gyptest-link-enable-winrt.py
copy to test/win/gyptest-link-enable-winrt-app-revision.py
index 283863ced7a09ee751a76ef58d235ec283672d2a..47709d41df30c416c38b956532686849467195a5 100644
--- a/test/win/gyptest-link-enable-winrt.py
+++ b/test/win/gyptest-link-enable-winrt-app-revision.py
@@ -5,7 +5,7 @@
# found in the LICENSE file.
"""
-Make sure msvs_enable_winrt works correctly.
+Make sure msvs_application_type_revision works correctly.
"""
import TestGyp
@@ -20,16 +20,18 @@ print 'This test is not currently working on the bots: https://code.google.com/p
sys.exit(0)
if (sys.platform == 'win32' and
- int(os.environ.get('GYP_MSVS_VERSION', 0)) >= 2013):
+ int(os.environ.get('GYP_MSVS_VERSION', 0)) >= 2015):
test = TestGyp.TestGyp(formats=['msvs'])
test.run_gyp('enable-winrt.gyp', chdir=CHDIR)
test.build('enable-winrt.gyp', 'enable_winrt_dll', chdir=CHDIR)
- test.build('enable-winrt.gyp', 'enable_winrt_missing_dll', chdir=CHDIR,
- status=1)
+ test.build('enable-winrt.gyp', 'enable_winrt_81_revision_dll', chdir=CHDIR)
scottmg 2015/05/13 22:17:32 and only refer to the new .gyp file here (removing
coop 2015/05/13 22:40:51 Done.
- test.build('enable-winrt.gyp', 'enable_winrt_winphone_dll', chdir=CHDIR)
+ test.build('enable-winrt.gyp', 'enable_winrt_82_revision_dll', chdir=CHDIR)
+
+ test.build('enable-winrt.gyp', 'enable_winrt_invalid_revision_dll',
+ chdir=CHDIR, status=1)
test.pass_test()
« test/win/gyptest-link-enable-winrt.py ('K') | « test/win/gyptest-link-enable-winrt.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698