Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: test/win/enable-winrt/enable-winrt.gyp

Issue 1132743006: Added msvs_application_type_revision for winrt compilation (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/win/enable-winrt/enable-winrt.gyp
diff --git a/test/win/enable-winrt/enable-winrt.gyp b/test/win/enable-winrt/enable-winrt.gyp
index 69f70189db94de5d35eede52d8075fcb5c72514c..cc3a4e63247543694859ec4a9b975b40ea1dff46 100644
--- a/test/win/enable-winrt/enable-winrt.gyp
+++ b/test/win/enable-winrt/enable-winrt.gyp
@@ -5,6 +5,33 @@
{
'targets': [
{
+ 'target_name': 'enable_winrt_81_revision_dll',
scottmg 2015/05/13 22:17:32 these would be better in a separate file, maybe wi
coop 2015/05/13 22:40:51 Done.
+ 'type': 'shared_library',
+ 'msvs_enable_winrt': 1,
+ 'msvs_application_type_revision' : '8.1'
scottmg 2015/05/13 22:17:32 nit; can you remove the space before : to match th
coop 2015/05/13 22:40:51 Done.
+ 'sources': [
+ 'dllmain.cc',
+ ],
+ },
+ {
+ 'target_name': 'enable_winrt_82_revision_dll',
+ 'type': 'shared_library',
+ 'msvs_enable_winrt': 1,
+ 'msvs_application_type_revision' : '8.2'
+ 'sources': [
+ 'dllmain.cc',
+ ],
+ },
+ {
+ 'target_name': 'enable_winrt_invalid_revision_dll',
+ 'type': 'shared_library',
+ 'msvs_enable_winrt': 1,
+ 'msvs_application_type_revision' : '999'
+ 'sources': [
+ 'dllmain.cc',
+ ],
+ },
+ {
'target_name': 'enable_winrt_dll',
'type': 'shared_library',
'msvs_enable_winrt': 1,

Powered by Google App Engine
This is Rietveld 408576698